Skip to content

Readable, grouped boundary picker - #480

Closed
wmobley wants to merge 1 commit into
developfrom
fix/ui-boundary-picker
Closed

wmobley wants to merge 1 commit into
developfrom
fix/ui-boundary-picker

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Problem

In problem formulation the Boundary dropdown showed hash-like ids instead of names, and the MINT registered regions listed dozens of overlapping numbered parts (for example TRINITY_1 … TRINITY_55) as separate entries.

Change

  • Boundary is a type-to-filter combobox (Radix popover + cmdk, like StandardVariableCombobox); options show names only, grouped and sorted by category with numeric ordering. Region ids are never rendered.
  • Numbered parts sharing a base name in one category collapse into one family ("Trinity (55 parts)"). Choosing the family saves all parts (GeometryCollection geometry; region_id filter with the part ids comma-joined); the chevron expands it to pick one part, which saves as before.
  • A category filter appears when a layer spans several categories.
  • ArcGIS layers get readable labels from three new optional layer keys in the adapter's _default_spatial_layers(): label_field, label_prefix, label_suffix ("GMA 1", "Harris County", district names).
  • The selected boundary is highlighted on the map; the rest of the layer is drawn faint.

Downstream check

Families exist only in the MINT registered-regions layer, which has no service URI; the adapter's boundary-query tasks (task_code.py) run only against the GMA, GCD and county ArcGIS layers, whose values are single. So the comma-joined value never reaches an ArcGIS where clause.

Tests

  • New spatial-boundaries.test.ts and SpatialScopeMap.test.tsx; MintParameters.test.tsx updated for the combobox.
  • vitest 157 files / 1607 tests pass; tsc and prettier clean; eslint 0 errors.
  • Not checked in a browser against dev yet. GMA labels need the adapter change deployed.

Do not merge until dev testing is scheduled.

🤖 Generated with Claude Code

…s collapsed

Boundary options show region names (never ids), sorted and grouped by
category, in a type-to-filter combobox. Numbered parts of one registered
region (TRINITY_1..55) collapse into one family entry that selects the
whole region and expands to single parts. The map shows one category at
a time and draws the selection highlighted over faint context. Layer
configs gain label_field, label_prefix and label_suffix so the GMA layer
reads 'GMA 1' instead of '1'.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 20, 2026 7:40pm UTC

@wmobley

wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Combined into #482 so all five build and deploy together.

@wmobley wmobley closed this Nov 20, 2026

This branch was successfully deployed

1 active deployment
Preview — b90ef9b5 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant