Skip to content

feat(flows): open a run's results from the web app - #445

Merged
wmobley merged 1 commit into
developfrom
feat/flow-results-download
Nov 20, 2026
Merged

wmobley merged 1 commit into
developfrom
feat/flow-results-download

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

C1(d) of the plan in #441 (flows in the MINT web app).

A result is a location in Tapis storage, which a browser cannot open.

Ensemble Manager

  • GET /executions/{id}/files also returns results: [{name, url, kind}]. kind is asked of Tapis with the caller's token, not guessed from the name. A folder result lists that folder; it listed the folder's parent.
  • New GET /executions/{id}/files/content?path=…&systemId=… streams one file with the caller's token. It serves only a run's result files, what lies inside a result folder, and the files beside a result file, on a system the results are on. .., empty segments, backslashes and control characters are refused (FILE_PATH_INVALID); anything else outside the results is FILE_NOT_IN_RESULTS. It does not follow a redirect, and no error carries the token or Tapis's body.

Web app

  • A file result has Download and Copy location. A folder result has Open folder, which opens the files dialog; a file there has Download when the route will serve it.
  • A location that is not Tapis storage or a web address is shown as text, never as a link.

Known and unchanged: the files listing has no check that the caller may read the run's thread; Tapis's own permissions are what stop a stranger. The download route has the same gap, narrowed to the run's results. To be closed on both routes in a follow-up.

Tests: Ensemble Manager 482 passing, web app 1312 passing, both type checks clean. The two Tapis calls relied on (stat, content) were checked against Tapis.

  • Checked in a browser on dev

A result is a location in Tapis storage, which a browser cannot open.

Ensemble Manager:
- the files listing says whether each result is a file or a folder, asked of
  Tapis with the caller's token, and lists a folder result itself where it
  listed the folder's parent
- a download route streams one file with the caller's token. It serves only a
  run's result files, what lies inside a result folder, and the files beside a
  result file, on the system the results are on

Web app:
- a file result has Download and Copy location; a folder result opens the
  files dialog, where each file the route serves has Download
- a location that is not Tapis storage or a web address is shown as text
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 20, 2026 1:19am UTC

@wmobley
wmobley merged commit e6139bd into develop Nov 20, 2026
41 checks passed

This branch was successfully deployed

1 active deployment
Preview — e495e949 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant