Repository navigation
feat(flows): open a run's results from the web app - #445
Merged
Merged
Conversation
A result is a location in Tapis storage, which a browser cannot open. Ensemble Manager: - the files listing says whether each result is a file or a folder, asked of Tapis with the caller's token, and lists a folder result itself where it listed the folder's parent - a download route streams one file with the caller's token. It serves only a run's result files, what lies inside a result folder, and the files beside a result file, on the system the results are on Web app: - a file result has Download and Copy location; a folder result opens the files dialog, where each file the route serves has Download - a location that is not Tapis storage or a web address is shown as text
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C1(d) of the plan in #441 (flows in the MINT web app).
A result is a location in Tapis storage, which a browser cannot open.
Ensemble Manager
GET /executions/{id}/filesalso returnsresults: [{name, url, kind}].kindis asked of Tapis with the caller's token, not guessed from the name. A folder result lists that folder; it listed the folder's parent.GET /executions/{id}/files/content?path=…&systemId=…streams one file with the caller's token. It serves only a run's result files, what lies inside a result folder, and the files beside a result file, on a system the results are on..., empty segments, backslashes and control characters are refused (FILE_PATH_INVALID); anything else outside the results isFILE_NOT_IN_RESULTS. It does not follow a redirect, and no error carries the token or Tapis's body.Web app
Known and unchanged: the files listing has no check that the caller may read the run's thread; Tapis's own permissions are what stop a stranger. The download route has the same gap, narrowed to the run's results. To be closed on both routes in a follow-up.
Tests: Ensemble Manager 482 passing, web app 1312 passing, both type checks clean. The two Tapis calls relied on (stat, content) were checked against Tapis.