Repository navigation
fix(ui): a flow's optional settings may stay empty, and Run names the ones it needs - #443
Merged
Merged
Conversation
… ones it needs Seen on dev: the settings step never completed for a flow, because every setting had to have a value and a flow's optional settings have no default in the catalog. For a flow the step is complete once saved. Run asks the plan which settings are required and names any the thread has no value for, before anything is submitted.
The Runs step repeated the settings check of the step gate, so it still said no models were set up for a flow with an optional setting left empty.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running the Dictionary flow in a browser against dev after #442.
INVALID_PARAMETERS) reads as a sentence.Checked in a browser with a local build against the dev services: the settings step reads Configured, Runs opens, the run completed and the four results are listed.
Tests: 1304 passing, type check clean.