Skip to content

fix(ui): a flow's optional settings may stay empty, and Run names the ones it needs - #443

Merged
wmobley merged 2 commits into
developfrom
fix/ui-flow-settings-gate
Nov 20, 2026
Merged

wmobley merged 2 commits into
developfrom
fix/ui-flow-settings-gate

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Found by running the Dictionary flow in a browser against dev after #442.

  • The settings step never completed for a flow: every setting had to have a value, and a flow's optional settings have no default in the catalog. For a flow the step is complete once saved. The Runs step repeated the same check and is changed with it.
  • Run asks the plan which settings are required and names any the thread has no value for, before anything is submitted. A missing output folder is then a message, not a failed run.
  • The adapter's refusal of a missing or malformed setting (INVALID_PARAMETERS) reads as a sentence.

Checked in a browser with a local build against the dev services: the settings step reads Configured, Runs opens, the run completed and the four results are listed.

Tests: 1304 passing, type check clean.

… ones it needs

Seen on dev: the settings step never completed for a flow, because every
setting had to have a value and a flow's optional settings have no default in
the catalog. For a flow the step is complete once saved. Run asks the plan
which settings are required and names any the thread has no value for, before
anything is submitted.
The Runs step repeated the settings check of the step gate, so it still said
no models were set up for a flow with an optional setting left empty.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 20, 2026 12:48am UTC

@wmobley
wmobley merged commit 01e6427 into develop Nov 20, 2026
40 checks passed

This branch was successfully deployed

1 active deployment
Preview — b2e2ad6a Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant