Skip to content

feat(modeling): ModelingHome + ProblemStatementsList + MintProblemStatement (1:1 port) - #12

Closed
mosoriob wants to merge 1 commit into
developfrom
feat/modeling-shell
Closed

mosoriob wants to merge 1 commit into
developfrom
feat/modeling-shell

Conversation

@mosoriob

@mosoriob mosoriob commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

1:1 port of the Modeling workflow shell screens from LitElement to React.

Deliverables

  • ModelingHome (23 LOC): Router shell, redirects to /modeling/problem-statements
  • ProblemStatementsList (582 LOC): Full CRUD with search/filter, permission-gated edit/delete, Apollo Client hooks
  • MintProblemStatement (~895 LOC): Master-detail layout with task listing, thread creation/navigation
  • MintThread (21 LOC): Placeholder thread detail view
  • modeling.ts (898 LOC): Hand-authored GraphQL types, hooks, and utilities
  • AlertDialog + Skeleton: New shared UI components (Radix-based)
  • App.tsx: Updated routing for /modeling/* paths

Tests

  • 17 unit tests for modeling utilities (all passing)

Branch

  • Base: develop
  • Branch: feat/modeling-shell

@mosoriob
mosoriob force-pushed the feat/modeling-shell branch from dc5059c to eeaa22b Compare June 6, 2026 01:12
@vercel

vercel Bot commented Jun 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
monorepo Error Error Jun 6, 2026 1:26am
monorepo-flal Ready Ready Preview, Comment Jun 6, 2026 1:26am

@mosoriob

mosoriob commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Code Review — PR #12: ModelingHome + ProblemStatementsList + MintProblemStatement

Verdict: Request Changes — 2 blocking issues (build fails), 1 warning.


Critical (blocking)

1. App.tsx: missing imports — build fails

npm run build exits with:

src/App.tsx(79,54): error TS2304: Cannot find name 'OAuth2CallbackPage'.
src/App.tsx(80,53): error TS2304: Cannot find name 'LoginRequiredPage'.

The PR adds two routes in App.tsx but forgets to import the components:

  • OAuth2CallbackPage exists at src/pages/OAuth2CallbackPage.tsx — just needs an import line added.
  • LoginRequiredPage does not exist anywhere in the codebase. Either create it or remove the route until it is implemented.

Fix needed in ui-react/src/App.tsx:

// add alongside the other page imports
import { OAuth2CallbackPage } from './pages/OAuth2CallbackPage';
// and one of:
//   create LoginRequiredPage at ./pages/LoginRequiredPage.tsx
//   OR remove the /login-required route for now

Warnings

2. console.error left in production catch blocks (6 occurrences)

ProblemStatementsList.tsx (×2) and MintProblemStatement.tsx (×4) contain bare console.error(err) statements in mutation catch handlers. In this codebase errors are surfaced to the user via useToast; the console.error leaks internal details in the browser console. Either remove it or use a proper logger abstraction if one exists.


What looks good

  • TypeScript is strict throughout — no any escape hatches, Maybe<T> used consistently.
  • All three components use shadcn/ui primitives and Apollo hooks in patterns matching the rest of the codebase.
  • Accessibility: aria-label, role, htmlFor/Label pairs are present on all interactive elements including tree nodes.
  • New alert-dialog.tsx and skeleton.tsx shadow the shadcn/ui API without adding new dependencies — clean approach.
  • GraphQL: fragments defined in modeling.ts, queries/mutations use generated typed hooks.
  • modeling-utils.test.ts: 17/17 tests pass covering getUserPermission, getLatestEvent, getLatestEventOfType, and generateModelingId.
  • No hardcoded credentials, secrets, or API keys.
  • Commit message is clean — no AI/authorship indicators.
  • Lint: 0 new errors or warnings introduced in the new files.

Two fixes needed before merge: add the missing import for OAuth2CallbackPage and either implement or remove LoginRequiredPage.

@mosoriob

mosoriob commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing as already merged: the branch's changes are already present in develop (rebasing onto develop produced an empty diff).

This branch had an error being deployed

1 failed and 1 active deployments
Preview – monorepo — eeaa22b7 Deployed Jun 6, 2026 by vercel[bot]
Preview – monorepo-flal — eeaa22b7 Deployed Jun 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant