Repository navigation
build: vendor libs3rdma 0.3.1 - #261
Merged
harshavardhana merged 1 commit intoSep 3, 2026
Merged
Conversation
Keeps the vendored client library in step with s3rdma 0.3.1. `s3rdma_version()` is the only runtime signal a consumer gets about the `.so` beside it, so leaving 0.3.0 here while aistor ships 0.3.1 would have the same version name two different builds. The behavioural change in 0.3.1 (s3rdma#28, demand-proportional internode credit grants) lives in libp2p_rdma, which this repo does not vendor — the client library differs only by its version string. Refreshed for consistency rather than for a fix.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
harshavardhana
added a commit
to harshavardhana/minio-cpp
that referenced
this pull request
Sep 14, 2026
Keeps the vendored client library in step with s3rdma 0.3.2, as minio#261 did for 0.3.1. `s3rdma_version()` is the only runtime signal a consumer gets about the `.so` beside it, so leaving 0.3.1 here while aistor ships 0.3.2 would have one version name two different builds. The change in 0.3.2 (s3rdma#29, attributing a landing buffer to its sender at allocation, without which the proportional credit grants from 0.3.1 never ran at all) lives in libp2p_rdma, which this repo does not vendor — the client library differs only by its version string. Refreshed for consistency rather than for a fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
harshavardhana
added a commit
to harshavardhana/minio-cpp
that referenced
this pull request
Sep 14, 2026
Keeps the vendored client library in step with s3rdma 0.3.2, as minio#261 did for 0.3.1. `s3rdma_version()` is the only runtime signal a consumer gets about the `.so` beside it, so leaving 0.3.1 here while aistor ships 0.3.2 would have one version name two different builds. The change in 0.3.2 (s3rdma#29, attributing a landing buffer to its sender at allocation, without which the proportional credit grants from 0.3.1 never ran at all) lives in libp2p_rdma, which this repo does not vendor — the client library differs only by its version string. Refreshed for consistency rather than for a fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: vendor libs3rdma 0.3.1
Keeps the vendored client library in step with s3rdma 0.3.1.
s3rdma_version()is the only runtime signal a consumer gets about the
.sobeside it, so leaving0.3.0 here while aistor ships 0.3.1 would have the same version name two
different builds.
The behavioural change in 0.3.1 (s3rdma#28, demand-proportional internode credit
grants) lives in libp2p_rdma, which this repo does not vendor — the client
library differs only by its version string. Refreshed for consistency rather
than for a fix.