Skip to content

build: vendor libs3rdma 0.3.1 - #261

Merged
harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:build/vendor-s3rdma-0.3.1
Sep 3, 2026
Merged

harshavardhana merged 1 commit into
minio:mainfrom
harshavardhana:build/vendor-s3rdma-0.3.1

Conversation

@harshavardhana

Copy link
Copy Markdown
Member

build: vendor libs3rdma 0.3.1

Keeps the vendored client library in step with s3rdma 0.3.1. s3rdma_version()
is the only runtime signal a consumer gets about the .so beside it, so leaving
0.3.0 here while aistor ships 0.3.1 would have the same version name two
different builds.

The behavioural change in 0.3.1 (s3rdma#28, demand-proportional internode credit
grants) lives in libp2p_rdma, which this repo does not vendor — the client
library differs only by its version string. Refreshed for consistency rather
than for a fix.

Keeps the vendored client library in step with s3rdma 0.3.1. `s3rdma_version()`
is the only runtime signal a consumer gets about the `.so` beside it, so leaving
0.3.0 here while aistor ships 0.3.1 would have the same version name two
different builds.

The behavioural change in 0.3.1 (s3rdma#28, demand-proportional internode credit
grants) lives in libp2p_rdma, which this repo does not vendor — the client
library differs only by its version string. Refreshed for consistency rather
than for a fix.
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (2)
  • vendor/s3rdma/lib/aarch64/libs3rdma.so.0
  • vendor/s3rdma/lib/x86_64/libs3rdma.so.0
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 882163c7-3347-4943-b03d-8183f5c807d3

📥 Commits

Reviewing files that changed from the base of the PR and between ff2189b and 429ea2a.

📒 Files selected for processing (2)
  • vendor/s3rdma/lib/aarch64/libs3rdma.so.0
  • vendor/s3rdma/lib/x86_64/libs3rdma.so.0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harshavardhana
harshavardhana merged commit 662d0c1 into minio:main Sep 3, 2026
13 checks passed
@harshavardhana
harshavardhana deleted the build/vendor-s3rdma-0.3.1 branch September 3, 2026 07:48
harshavardhana added a commit to harshavardhana/minio-cpp that referenced this pull request Sep 14, 2026
Keeps the vendored client library in step with s3rdma 0.3.2, as minio#261 did for
0.3.1. `s3rdma_version()` is the only runtime signal a consumer gets about the
`.so` beside it, so leaving 0.3.1 here while aistor ships 0.3.2 would have one
version name two different builds.

The change in 0.3.2 (s3rdma#29, attributing a landing buffer to its sender at
allocation, without which the proportional credit grants from 0.3.1 never ran
at all) lives in libp2p_rdma, which this repo does not vendor — the client
library differs only by its version string. Refreshed for consistency rather
than for a fix.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
harshavardhana added a commit to harshavardhana/minio-cpp that referenced this pull request Sep 14, 2026
Keeps the vendored client library in step with s3rdma 0.3.2, as minio#261 did for
0.3.1. `s3rdma_version()` is the only runtime signal a consumer gets about the
`.so` beside it, so leaving 0.3.1 here while aistor ships 0.3.2 would have one
version name two different builds.

The change in 0.3.2 (s3rdma#29, attributing a landing buffer to its sender at
allocation, without which the proportional credit grants from 0.3.1 never ran
at all) lives in libp2p_rdma, which this repo does not vendor — the client
library differs only by its version string. Refreshed for consistency rather
than for a fix.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant