Repository navigation
refactor(validate): one checking core with validateSpace and validateFile as views - #159
Merged
Merged
Conversation
This was referenced Oct 16, 2026
mindsocket
marked this pull request as ready for review
October 16, 2026 03:56
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
…File as views - One core, validateNodes, runs all checks. - validateSpace and validateFile are two views over it. - The CLI resolves a file's space once. - No behaviour change. The no-hierarchy discrepancy is preserved and pinned by a test.
…type error measured: directory order differs on Linux, where another fixture's AJV /type const error came first and has no allowedValues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154. Stacked on #158.
Summary
validateNodes, withvalidateSpaceandvalidateFileas views over it.validateFilereturns the part of a full run that belongs to one file.validateFilesignature andFileValidationResultare unchanged, and there are no new exports.Tests
validateFilereports the issuesvalidateSpacereports for that file.Note
The two views key an invalid
typeissue differently (schema:type:…againstschema:/type:enum:…). This predates the refactor (measured: same onmain); the parity test normalises it.