Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes strengthening installer hash integrity checks.
No open issues 🎉
What changed in this PR
This PR strengthens WinGet’s installer integrity checks by requiring hashes for REST installers except Microsoft Store installers and removing the empty-hash verification bypass.
Changes:
- Centralizes installer hash requirements and skips REST installers missing a required hash.
- Rejects empty or unequal hashes during verification and supports logging malformed hashes.
- Adds regression tests, updates test helpers to supply real hashes, and documents the behavior change.
| File | Description |
|---|---|
src/AppInstallerRepositoryCore/Rest/Schema/1_0/Json/ManifestDeserializer_1_0.cpp |
Skips installers missing required hashes. |
src/AppInstallerCommonCore/Public/winget/ManifestCommon.h |
Declares the shared hash-requirement helper. |
src/AppInstallerCommonCore/Manifest/ManifestValidation.cpp |
Uses the shared hash requirement during validation. |
src/AppInstallerCommonCore/Manifest/ManifestCommon.cpp |
Defines the Microsoft Store hash exemption. |
src/AppInstallerCommonCore/AppInstallerTelemetry.cpp |
Logs hashes without requiring valid SHA256 lengths. |
src/AppInstallerCLITests/WorkflowCommon.h |
Declares the test installer hash helper. |
src/AppInstallerCLITests/WorkflowCommon.cpp |
Supplies computed hashes in download overrides. |
src/AppInstallerCLITests/WorkFlow.cpp |
Tests missing, mismatched, and unequal-length hashes. |
src/AppInstallerCLITests/RestInterface_1_0.cpp |
Tests REST hash requirements and the Store exemption. |
src/AppInstallerCLITests/InstallFlow.cpp |
Updates installation overrides with computed hashes. |
src/AppInstallerCLICore/Workflows/DownloadFlow.cpp |
Rejects empty hashes and compares both complete ranges. |
doc/release-notes/1.31/require-rest-installer-hash.md |
Adds a user-facing release note. |
Review effort: Balanced
AmirMS (AmelBawa-msft)
approved these changes
Nov 2, 2026
ranm-msft
approved these changes
Nov 3, 2026
ranm-msft
left a comment
ranm-msft
left a comment
Contributor
There was a problem hiding this comment.
Hash requirement propagation and REST validation look correct; focused test coverage and exact-head CI are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
REST installer parsing did not require hashes, which is only acceptable for installer types where we do not control the download (Store-based MSIX installs only right now). Make not having a required hash result in an ignored installer, as we do for other required fields.
Hash validation further allowed the empty hash to accept anything. While that matches with some form of expectation, we don't really want that. Hash validation is now required to occur if the task is invoked.
🔍 Validation
Added new tests for the hash validation and REST response parsing.
Fixed a number of test overrides that relied on the validation skip.
Microsoft Reviewers: Open in CodeFlow