Repository navigation
Add TreeView data model and hook up existing test data - #4304
Merged
Derek Keeler (d3r3kk) merged 8 commits intoFeb 7, 2019
Merged
Conversation
Don Jayamanne (DonJayamanne)
requested changes
Feb 6, 2019
Don Jayamanne (DonJayamanne)
left a comment
Don Jayamanne (DonJayamanne)
left a comment
There was a problem hiding this comment.
Simple refactoring, move files, and rename stuff.
Please remove Python prefix from class names.
Don Jayamanne (DonJayamanne)
approved these changes
Feb 6, 2019
For microsoft#4273 - Make Python Test View Provider injectable (testable) - Maps `Tests` object to TreeViewItem hierarchy - Adds a Event (subscription) model to the TestStorageService
- Ensure all properties in the TestTreeItem are RO - Remove `Python` from the names of classes/enums
- simplify name of event for test store updates -
- move TreeView files to more appropriate location - move registrations to more appropriate location - clean up some lengthy import statements
Derek Keeler (d3r3kk)
force-pushed
the
4273_test_explorer_datamodel
branch
from
February 6, 2019 23:04
c776ad9 to
7dfaabe
Compare
Codecov Report
@@ Coverage Diff @@
## master #4304 +/- ##
========================================
+ Coverage 57% 79% +22%
========================================
Files 345 422 +77
Lines 14459 19336 +4877
Branches 2242 3106 +864
========================================
+ Hits 8234 15248 +7014
+ Misses 5696 4085 -1611
+ Partials 529 3 -526
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4273 & #4274
Testsobject toTreeViewItemhierarchyTestStorageServiceNote: This is the first in a line of PRs that I will submit on this issue, the primary purpose for this to be merged at this early time is to unblock others from submitting work against the Test Explorer feature as well.
Has a news entry file (remember to thank yourself!)Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)