Repository navigation
WIP - Add Support for Xonsh shell - #3488
Owen Campbell (meatballs) wants to merge 6 commits into
Conversation
|
|
|
Owen Campbell (@meatballs) |
Don Jayamanne (DonJayamanne)
left a comment
Don Jayamanne (DonJayamanne)
left a comment
There was a problem hiding this comment.
Unfortunately the tests are failing.
And we haven't modified the code to appropriately detect the shell.
See below https://github.com/Microsoft/vscode-python/blob/7de3383ee4940c3f7101893e38b7620306637336/src/client/common/terminal/helper.ts#L50
Owen Campbell (meatballs)
changed the title
|
I've updated the unit test suite and Travis is now happy but I don't understand the Azure pipeline failure. |
|
Don Jayamanne (@DonJayamanne) - If there is anything you need from us on the xonsh side, please let us know |
| return [`source ${scriptFile.fileToCommandArgument()}`]; | ||
|
|
||
| if (targetShell === TerminalShellType.xonsh) { | ||
| return [`conda ${scriptFile.fileToCommandArgument()}`]; |
There was a problem hiding this comment.
This will not work.
What if the environment is NOT conda?
E.g. assume you have a virtual environment or pipenv environment.
|
Unfortunately it has been 4 weeks since the last commit on this PR, and as CI isn't passing, I'm closing this PR due to inactivity. |
For #3487
I've very quickly hacked some changes to add support for the xonsh shell. I realise there is more to do here, but I'm not at all familiar with TypeScript so I'll need a little help from here on.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)