Repository navigation
testing: improve performance of large test discovery - #22414
Closed
Connor Peet (connor4312) wants to merge 2 commits into
Closed
Connor Peet (connor4312) wants to merge 2 commits into
Connor Peet (connor4312) wants to merge 2 commits into
Conversation
Avoids expensive string conversions and (to a lesser degree) buffer concatenations. Reduces time in the extension host in the lsprotocol repo from 17s -> 950ms for me. Original profile: Profile with these changes:
Connor Peet (connor4312)
force-pushed
the
connor4312/improve-test-discovery-perf
branch
from
November 3, 2023 01:43
ed60acf to
5a24096
Compare
Member
|
Connor Peet (@connor4312) we are working on replacing this with |
Member
Author
|
It looks good at first glance, and it avoids both the pitfalls I fixed in this PR. I'll validate when it lands 🙂 |
Member
|
We are working on moving the communication to use |
Karthik Nadig (karthiknadig)
deleted the
connor4312/improve-test-discovery-perf
branch
June 13, 2024 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids expensive string conversions and (to a lesser degree) buffer concatenations. Reduces time in the extension host in the lsprotocol repo from 17s -> 950ms for me.
Original profile:
vscode-profile-2023-11-02-16-35-20.cpuprofile
Profile with these changes:
vscode-profile-2023-11-02-17-27-45.cpuprofile