Ensure debugger breaks on `assert` failures by DonJayamanne · Pull Request #1599 · microsoft/vscode-python

Don Jayamanne (DonJayamanne) · 2018-05-03T23:30:50Z

This pull request:

Has a title summarizes what is changing
Includes a news entry file (remember to thank yourself!)
Has unit tests & code coverage is not adversely affected (within reason)
Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Mikhail Arkhipov (MikhailArkhipov) · 2018-05-04T19:22:02Z

+        if (typeName || desc) {
            let ex: IPythonException = {
                TypeName: typeName,
                Description: desc


OK to be undefined or does it need to be empty string for instance?

Ensure debugger breaks on assert failures

7e0c0a8

Mikhail Arkhipov (MikhailArkhipov) reviewed May 4, 2018

View reviewed changes

Mikhail Arkhipov (MikhailArkhipov) approved these changes May 4, 2018

View reviewed changes

Don Jayamanne (DonJayamanne) merged commit a740016 into microsoft:master May 7, 2018

Don Jayamanne (DonJayamanne) deleted the issue1194 branch June 20, 2018 03:17

lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019

Navigation Menu