Skip to content

Add tests for log points in the experimental debugger - #1583

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue1582
May 7, 2018
Merged

Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue1582

Conversation

@DonJayamanne

Copy link
Copy Markdown

Fixes #1582
Was not added in previous release as this was purely a PTSVD change.
Adding tests in VSC to ensure we do not regress.

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov

codecov Bot commented May 7, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #1583 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1583      +/-   ##
=========================================
- Coverage   71.53%   71.4%   -0.13%     
=========================================
  Files         274     273       -1     
  Lines       12733   12700      -33     
  Branches     2286    2282       -4     
=========================================
- Hits         9108    9068      -40     
- Misses       3493    3496       +3     
- Partials      132     136       +4
Impacted Files Coverage Δ
src/client/debugger/mainV2.ts 75% <0%> (-5.65%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (-0.66%) ⬇️
src/client/providers/formatProvider.ts 94.23% <0%> (-0.32%) ⬇️
src/client/formatters/helper.ts 100% <0%> (ø) ⬆️
src/client/common/types.ts 100% <0%> (ø) ⬆️
src/client/common/application/applicationShell.ts 23.07% <0%> (ø) ⬆️
src/client/common/installer/productNames.ts 100% <0%> (ø) ⬆️
src/client/formatters/baseFormatter.ts 75.34% <0%> (ø) ⬆️
src/client/formatters/blackFormatter.ts
src/client/common/configSettings.ts 88.16% <0%> (+0.21%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0526967...955a867. Read the comment docs.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 8028931 into microsoft:master May 7, 2018
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the issue1582 branch June 20, 2018 03:17
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for log points in experimental debugger

2 participants