Skip to content

Remove unused setting disablePromptForFeatures #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 1 commit into from
May 7, 2018
Merged

Remove unused setting disablePromptForFeatures #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/3 Code Health/1551.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unused setting `disablePromptForFeatures`.
20 changes: 0 additions & 20 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,26 +1156,6 @@
"description": "Whether to check if Python is installed (also warn when using the macOS-installed Python).",
"scope": "resource"
},
"python.disablePromptForFeatures": {
"type": "array",
"default": [],
"description": "Do not display a prompt to install these features",
"items": {
"type": "string",
"default": "pylint",
"description": "Feature",
"enum": [
"flake8",
"mypy",
"pep8",
"pylama",
"prospector",
"pydocstyle",
"pylint"
]
},
"scope": "resource"
},
"python.envFile": {
"type": "string",
"description": "Absolute path to a file containing environment variable definitions.",
Expand Down
4 changes: 0 additions & 4 deletions src/client/common/configSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export class PythonSettings extends EventEmitter implements IPythonSettings {
public jediPath = '';
public jediMemoryLimit = 1024;
public envFile = '';
public disablePromptForFeatures: string[] = [];
public venvPath = '';
public venvFolders: string[] = [];
public devOptions: string[] = [];
Expand Down Expand Up @@ -136,9 +135,6 @@ export class PythonSettings extends EventEmitter implements IPythonSettings {

// tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion
const lintingSettings = systemVariables.resolveAny(pythonSettings.get<ILintingSettings>('linting'))!;
// tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion
this.disablePromptForFeatures = pythonSettings.get<string[]>('disablePromptForFeatures')!;
this.disablePromptForFeatures = Array.isArray(this.disablePromptForFeatures) ? this.disablePromptForFeatures : [];
if (this.linting) {
Object.assign<ILintingSettings, ILintingSettings>(this.linting, lintingSettings);
} else {
Expand Down
1 change: 0 additions & 1 deletion src/client/common/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ export interface IPythonSettings {
readonly sortImports?: ISortImportSettings;
readonly workspaceSymbols?: IWorkspaceSymbolSettings;
readonly envFile: string;
readonly disablePromptForFeatures: string[];
readonly disableInstallationChecks: boolean;
readonly globalModuleInstallation: boolean;
}
Expand Down