Skip to content

Add PYTHONPATH to search paths used by the analysis engine - #1388

Merged
Don Jayamanne (DonJayamanne) merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1327AddPYTHONPATH
Apr 13, 2018
Merged

Don Jayamanne (DonJayamanne) merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1327AddPYTHONPATH

Conversation

@DonJayamanne

Copy link
Copy Markdown

Fixes #1327

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov

codecov Bot commented Apr 13, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #1388 into master will decrease coverage by 0.21%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   71.01%   70.79%   -0.22%     
==========================================
  Files         269      269              
  Lines       12416    12474      +58     
  Branches     2199     2207       +8     
==========================================
+ Hits         8817     8831      +14     
- Misses       3461     3506      +45     
+ Partials      138      137       -1
Impacted Files Coverage Δ
src/client/common/variables/types.ts 100% <ø> (ø) ⬆️
src/client/activation/analysis.ts 15.85% <20%> (+0.39%) ⬆️
src/client/linters/lintingEngine.ts 90.35% <0%> (-0.88%) ⬇️
src/client/telemetry/constants.ts 100% <0%> (ø) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd5095...fdc8be4. Read the comment docs.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit d5f386d into microsoft:master Apr 13, 2018
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the issue1327AddPYTHONPATH branch June 20, 2018 03:18
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include PYTHONPATH into searchPaths for the new analysis engine

2 participants