Repository navigation
Pass necessary flags to ptvsd during attach - #1332
Merged
Don Jayamanne (DonJayamanne) merged 3 commits intoApr 10, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
- Coverage 71.1% 71.05% -0.05%
==========================================
Files 269 269
Lines 12395 12398 +3
Branches 2198 2199 +1
==========================================
- Hits 8814 8810 -4
- Misses 3447 3451 +4
- Partials 134 137 +3
Continue to review full report at Codecov.
|
| debugConfiguration.debugOptions.push(DebugOptions.FixFilePathCase); | ||
| } | ||
| if (!this.serviceContainer.get<IPlatformService>(IPlatformService).isWindows) { | ||
| debugConfiguration.debugOptions.push(DebugOptions.FilePathIsCaseSensitive); |
There was a problem hiding this comment.
I don't think Mac is case sensitive by default
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
Apr 7, 2018
Author
|
Thanks, might have to revise the name. This depends on what ptvsd is doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1331
This pull request: