Skip to content

Pass necessary flags to ptvsd during attach - #1332

Merged
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue1331
Apr 10, 2018
Merged

Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue1331

Conversation

@DonJayamanne

Copy link
Copy Markdown

Fixes #1331

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov

codecov Bot commented Apr 6, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #1332 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage    71.1%   71.05%   -0.05%     
==========================================
  Files         269      269              
  Lines       12395    12398       +3     
  Branches     2198     2199       +1     
==========================================
- Hits         8814     8810       -4     
- Misses       3447     3451       +4     
- Partials      134      137       +3
Impacted Files Coverage Δ
src/client/debugger/Common/Contracts.ts 100% <100%> (ø) ⬆️
...lient/debugger/configProviders/pythonV2Provider.ts 100% <100%> (ø) ⬆️
src/client/debugger/PythonProcess.ts 45.83% <0%> (-3.75%) ⬇️
src/client/activation/classic.ts 97.5% <0%> (-0.07%) ⬇️
src/client/extension.ts 96.09% <0%> (+0.03%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f42f0...69bb1c8. Read the comment docs.

debugConfiguration.debugOptions.push(DebugOptions.FixFilePathCase);
}
if (!this.serviceContainer.get<IPlatformService>(IPlatformService).isWindows) {
debugConfiguration.debugOptions.push(DebugOptions.FilePathIsCaseSensitive);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Mac is case sensitive by default

@DonJayamanne

Copy link
Copy Markdown
Author

Thanks, might have to revise the name. This depends on what ptvsd is doing.

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 7887803 into microsoft:master Apr 10, 2018
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the issue1331 branch June 20, 2018 03:18
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass flag FilePathIsCaseSensitive to PTVSD when attaching

2 participants