Skip to content

Logging cleanup: move and split files. - #11161

Merged
Eric Snow (ericsnowcurrently) merged 13 commits into
microsoft:masterfrom
ericsnowcurrently:logging-cleanup-move-and-split-files
May 5, 2020
Merged

Eric Snow (ericsnowcurrently) merged 13 commits into
microsoft:masterfrom
ericsnowcurrently:logging-cleanup-move-and-split-files

Conversation

@ericsnowcurrently

@ericsnowcurrently Eric Snow (ericsnowcurrently) commented Apr 14, 2020 •

Copy link
Copy Markdown

For #9837.

This change is strictly about moving code around. Other PRs

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • [ ] Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.

Comment thread src/client/logging/index.ts
@ericsnowcurrently
Eric Snow (ericsnowcurrently) force-pushed the logging-cleanup-move-and-split-files branch from 56fff95 to af60cfd Compare May 5, 2020 17:59
@sonarqubecloud

sonarqubecloud Bot commented May 5, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently
Eric Snow (ericsnowcurrently) merged commit 899c6cd into microsoft:master May 5, 2020
@ericsnowcurrently
Eric Snow (ericsnowcurrently) deleted the logging-cleanup-move-and-split-files branch May 5, 2020 22:21
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants