Repository navigation
Work around for VSC Bug - Fix Path Mappings to lowercase the drive letter #5362
Description
When using path mappings on windows, ensure the drive letter is lower cased.
I.e. when user uses the following setup, ${workspaceFolder} gets translated to a path with an upper case drive letter.
"pathMappings": [
{
"localRoot": "${workspaceFolder}/modules/rfidreader/",
"remoteRoot": "/app/"
}
],
Activity
[-]Path Mappings[/-][+]Fix Path Mappings to lowercase the drive letter[/+][-]Fix Path Mappings to lowercase the drive letter[/-][+]Work around for VSC Bug - Fix Path Mappings to lowercase the drive letter[/+]DonJayamanne commentedon Jun 12, 2019
Prescribed Solution:
localRootof path mappings and convert drive letter to lower case (on windows)karrtikr commentedon Jun 18, 2019
When the
pathmappingsis not an empty list,localRootis not being lowercased.DonJayamanne commentedon Jun 18, 2019
Kim-Adeline Miguel (@kimadeline) I can see where this will fail.
We're lower casing ONLY if pathMappings.length === 0.
We need to change it and ensure all paths in path mappings are lower cased.
Thanks Kartik Raj (@karrtikr)
karrtikr commentedon Jun 18, 2019
Suggestion
src\client\debugger\extension\hooks\childProcessAttachService.ts->fixPathMappings().Use similar logic to resolve localRoot
DonJayamanne commentedon Jun 18, 2019
Kim-Adeline Miguel (@kimadeline) I agree with Kartik Raj (@karrtikr) His suggestion puts the changes in the right place.
karrtikr commentedon Jun 19, 2019
validated