Repository navigation
"Go to definition" on module takes you to __init__.py instead of actual module #3519
Description
Environment data
- VS Code version: 1.29.1
- Extension version (available under the Extensions sidebar): 2018.11.0
- OS and version: Windows 10 64-bit
- Python version (& distribution if applicable, e.g. Anaconda): Conda 3.7.1
- Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
- Relevant/affected Python packages and their versions: None
Actual behavior
"Go to definition" on module takes me to __init__.py rather than the module I actually selected.
Expected behavior
"Go to definition" on module takes me to the module I selected.
Steps to reproduce:
Using the jedi language engine:
Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
# there is no output, as seen in the screencap above
Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
# there is no output, as seen in the screencap above
Activity
d3r3kk commentedon Nov 30, 2018
Fredrik Averpil (@fredrikaverpil) thanks for the report.
Could you please try the new Python Language Server and let us know if the behaviour persists? You can do this by going into settings (
Ctrl+,) and uncheckingPython: Jedi Enabled, then reload VSCode.fredrikaverpil commentedon Dec 3, 2018
Hey Derek Keeler (@d3r3kk)
When I enable the MS Python Language Server it's actually even worse. Now I can't even go to the definition of the
hellofunction, which works if using jedi. See screenshots when I attempt the "gotodef" for both the module and the function, both resulting in "No definition found for 'hello'".d3r3kk commentedon Jan 7, 2019
Interesting, I cannot seem to replicate the issue at all with the Python Language Server:
Could you please retry with the latest Python Language Server and let us know if things have improved on your end?
I can reproduce this with
Jedihowever, and worse yet, our 'insiders' build seems to fail altogether with code navigation in this regard (we've updated to a newer version ofJedifor insiders). I'm marking this as a Jedi bug and something to track before we release.d3r3kk commentedon Jan 7, 2019
Here's the results on our insiders build with the latest
Jedi:d3r3kk commentedon Jan 7, 2019
Don Jayamanne (@DonJayamanne) FYI
11 remaining items
DonJayamanne commentedon Jan 31, 2019
Unable to replicate in the latest version of Jedi and parso, hence we should upgrade.
russelldavis commentedon Feb 7, 2019
Don Jayamanne (@DonJayamanne) I started putting together a PR to upgrade to the latest version of Jedi and parso to fix this issue, but even with the new versions, I am still able to reproduce the bug (in VSCode 1.31.0 as well as the insiders build). It's the issue shown in Fredrik Averpil (@fredrikaverpil)'s gif above.
brettcannon commentedon Dec 20, 2019
Is this still an issue for anyone?
fredrikaverpil commentedon Dec 21, 2019
Brett Cannon (@brettcannon) I cannot reproduce this anymore in vscode 1.41.1. To me, this issue seems completely fixed. I've tested the same case as above with both jedi and the python language server! 👍 🎉