Activity

1. amueller commented on Nov 10, 2018

   

   Andreas Mueller (amueller)

   on Nov 10, 2018 · Hidden as off-topic

   Last edited by amueller

   show commentMore actions
2. DonJayamanne commented on Nov 11, 2018

   

   Don Jayamanne (DonJayamanne)

   on Nov 11, 2018 · Hidden as off-topic

   show commentMore actions
3. amueller commented on Nov 11, 2018

   

   Andreas Mueller (amueller)

   on Nov 11, 2018 · Hidden as off-topic

   show commentMore actions
4. cbrnr commented on Nov 12, 2018

   

   Clemens Brunner (cbrnr)

   on Nov 12, 2018

   More actions

   #481 is certainly related because it also concerns proper PEP8-style indentation.

   👍React with 👍1Reacted by Andreas Mueller
5. DonJayamanne commented on Nov 12, 2018

   

   Don Jayamanne (DonJayamanne)

   on Nov 12, 2018

   More actions

   This issue was moved to microsoft/python-language-server#385
6. Don Jayamanne (DonJayamanne)

   closed this as completedon Nov 12, 2018
7. Don Jayamanne (DonJayamanne)

   reopened this on Nov 12, 2018
8. Don Jayamanne (DonJayamanne)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   needs PR

   area-formatting

   upstream-language server

   on Nov 12, 2018
9. jakebailey commented on Nov 12, 2018

   

   Jake Bailey (jakebailey)

   on Nov 12, 2018

   Member

   More actions

   I'm pretty sure this isn't a language server problem. The extension tells the editor what to do on enter here:

   https://github.com/Microsoft/vscode-python/blob/d0c239fcc78fee9a05713ced15b08e6806affc24/src/client/extension.ts#L121-L140

   This is distinct from textDocument/onTypeFormatting.
10. Don Jayamanne (DonJayamanne)

    added

    needs decision

    importantIssue identified as high-priorityIssue identified as high-priority

    needs proposalNeed to make some design decisionsNeed to make some design decisions

    on Nov 12, 2018
11. 23 remaining items

    Load more
12. Brett Cannon (brettcannon)

    removed

    validate fix

    on Jan 8, 2019
13. Don Jayamanne (DonJayamanne)

    closed this as completedon Jan 15, 2019
14. ghost removed

    needs PR

    on Jan 15, 2019
15. lock

    locked as resolved and limited conversation to collaborators on Feb 12, 2019
16. ericsnowcurrently commented on Jun 11, 2019

    

    Eric Snow (ericsnowcurrently)

    on Jun 11, 2019

    Last edited by DonJayamanne

    More actions

    Prescribed Solution:

    • Modify src/client/extension.ts
    • Modify the beforeText setting to use the below regex:
    • Add tests

    There may be a more correct regex to use:

    /^(?!\s+\\)[^#\n]+\\$/

    See #5821 (comment).
17. Eric Snow (ericsnowcurrently)

    reopened this on Jun 11, 2019
18. ghost added

    triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

    on Jun 11, 2019
19. Brett Cannon (brettcannon)

    added

    needs PR

    feature-*

    and removed

    triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

    feature-*

    on Jun 11, 2019
20. Don Jayamanne (DonJayamanne)

    removed this from the 2019, week 1 - Jan Sprint 1 milestone on Jun 12, 2019
21. karrtikr commented on Jun 26, 2019

    

    Kartik Raj (karrtikr)

    on Jun 26, 2019

    More actions

    Closing as fix for #4241 will cover it.
22. Kartik Raj (karrtikr)

    closed this as completedon Jun 26, 2019
23. ghost removed

    needs PR

    on Jun 26, 2019