Skip to content

Ensure types used in telemetry are strongly typed #2904

Closed

Description

Ensuring the type names map easily to the telemetry names, makes it easier to discover (avoids having to document or keep documentation in sync) properties captured in the Telemetry.

We should also consider adding strongly typed members for the durations component of telemetry.

Activity

  1. changed the title [-]Ensure type names match with the telemetry names[/-] [+]Ensure types used in telemetry are strongly typed[/+] on Jan 17, 2019
  2. DonJayamanne commented on Jan 17, 2019

    @DonJayamanne
    Author

    Benefit of the change:

    • Today when we use sendTelemetryEvent we pass in the event name and some properties. The two go hand in hand. However there's no way to ensure that we pass in all valid properties for a given telemetry.
      This PR will ensure that given a telemetry event we can define the exact telemetry properties that are expected.
    • Benefits - strong typing & looking at one file we can tell exactly what will be captured.
  3. DonJayamanne commented on Jan 30, 2019

    @DonJayamanne
    Author

    Fixed in latest release

  4. locked as resolved and limited conversation to collaborators on Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

debtCode quality issues

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions