You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ensure types used in telemetry are strongly typed #2904
Ensuring the type names map easily to the telemetry names, makes it easier to discover (avoids having to document or keep documentation in sync) properties captured in the Telemetry.
We should also consider adding strongly typed members for the durations component of telemetry.
Today when we use sendTelemetryEvent we pass in the event name and some properties. The two go hand in hand. However there's no way to ensure that we pass in all valid properties for a given telemetry.
This PR will ensure that given a telemetry event we can define the exact telemetry properties that are expected.
Benefits - strong typing & looking at one file we can tell exactly what will be captured.
Activity
[-]Ensure type names match with the telemetry names[/-][+]Ensure types used in telemetry are strongly typed[/+]DonJayamanne commentedon Jan 17, 2019
Benefit of the change:
sendTelemetryEventwe pass in the event name and some properties. The two go hand in hand. However there's no way to ensure that we pass in all valid properties for a given telemetry.This PR will ensure that given a telemetry event we can define the exact telemetry properties that are expected.
Use enums for telemetry event names (#3992)
Strong typing of telemetry properties (#4031)
DonJayamanne commentedon Jan 30, 2019
Fixed in latest release