Implement implicit trigger points for Create Environment #21965

Activity

1. Karthik Nadig (karthiknadig)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   needs PRReady to be worked onReady to be worked on

   on Sep 11, 2023
2. Karthik Nadig (karthiknadig)

   self-assigned this

   on Sep 11, 2023
3. Karthik Nadig (karthiknadig)

   added this to the September 2023 milestone on Sep 25, 2023
4. Karthik Nadig (karthiknadig)

   closed this as completedin #22071on Sep 25, 2023
5. Karthik Nadig (karthiknadig)

   added a commit that references this issue on Sep 25, 2023

   Show a prompt asking users if they want to create environment (#22071)

   ...

   337b862
6. github-actions

   removed

   needs PRReady to be worked onReady to be worked on

   on Sep 25, 2023
7. Karthik Nadig (karthiknadig)

   added

   verification-neededVerification of issue is requestedVerification of issue is requested

   on Sep 25, 2023
8. karthiknadig commented on Sep 25, 2023

   

   Karthik Nadig (karthiknadig)

   on Sep 25, 2023

   Last edited by karthiknadig

   MemberAuthor

   More actions

   Verification Steps:

   1. Open a folder containing python file and at least one requirements.txt file.
   2. Ensure there are no .venv or .conda in the workspace.
   3. The selected python should be the system python (i.e., not a virtual environment)
   4. Set python.createEnvironment.trigger to prompt in user settings.
   5. Open the python file and click on the run in terminal button at the top right corner in the editor
   6. you should see a prompt:
      
9. github-actions

   added

   on-testplanAdded to test planAdded to test plan

   on Sep 25, 2023
10. Raymond Zhao (rzhao271)

    added

    verifiedVerification succeededVerification succeeded

    and removed

    verifiedVerification succeededVerification succeeded

    on Sep 26, 2023
11. rzhao271 commented on Sep 26, 2023

    

    Raymond Zhao (rzhao271)

    on Sep 26, 2023

    More actions

    I don't see it yet. Will try again tomorrow unless someone else wants to give it a try

    Highlighted is the Python version I'm using, and the play button on the top-right is what I'm pressing to try and get the notification.
    

    main.py

    print("hello")
    

    requirements.txt

    black==23.9.1
    click==8.1.7
    colorama==0.4.6
    mypy==1.5.1
    mypy-extensions==1.0.0
    packaging==23.1
    pathspec==0.11.2
    platformdirs==3.10.0
    typing_extensions==4.8.0
    
12. Raymond Zhao (rzhao271)

    added

    verifiedVerification succeededVerification succeeded

    on Sep 26, 2023
13. rzhao271 commented on Sep 26, 2023

    

    Raymond Zhao (rzhao271)

    on Sep 26, 2023

    More actions

    Verified after setting python.createEnvironment.trigger to "prompt".
14. Eleanor Boyd (eleanorjboyd)

    added a commit that references this issue on Oct 2, 2023

    Show a prompt asking users if they want to create environment (micros…

    ...

    0d8a32d
15. github-actions

    locked as resolved and limited conversation to collaborators on Oct 27, 2023
16. Wes McKinney (wesm)

    added 2 commits that reference this issue on Mar 28, 2024

    Merged PR posit-dev/positron-python#224: Merge/2023.18

    ...

    c67a9c7

    Merged PR posit-dev/positron-python#224: Merge/2023.18

    ...

    ae98109