Skip to content

Notebook support for linting and formatting #21142

Closed

Description

  • Implement Notebook support in pygls
  • Implement Linting for notebooks in pylint.
  • Implement Linting for notebooks in flake8.
  • Implement Linting for notebooks in mypy.
  • Implement Formatting for notebooks in black
  • Implement Formatting for notebooks in autopep8

Activity

  1. rebornix commented on May 9, 2023

    @rebornix

    Karthik Nadig (@karthiknadig) currently we have "Format Notebook" command in the core and also notebook format on save. If users have black extensions installed, it works as expected. May I ask if this would change how we run formatters from the core?

  2. karthiknadig commented on May 9, 2023

    @karthiknadig
    MemberAuthor

    From what I can tell, it should not. The LSP server registers itself as a server that can handle notebooks. When I have a prototype ready, we can look at how LSP client handles notebook mode registration.

  3. eleanorjboyd commented on Dec 16, 2024

    @eleanorjboyd
    Member

    Karthik Nadig (@karthiknadig) Should this be closed now that the same feature requests are in the tools extensions?

  4. karthiknadig commented on Dec 16, 2024

    @karthiknadig
    MemberAuthor

    That is correct the requests are in the tools extensions

  5. rootsmusic commented on Dec 16, 2024

    @rootsmusic

    That is correct the requests are in the tools extensions

    Karthik Nadig (@karthiknadig) I don't see this request in autopep8

    (Found for flake8.)

  6. karthiknadig commented on Dec 16, 2024

    @karthiknadig
    MemberAuthor

    rootsmusic There is no support for notebooks in autopep8. So we can't provide it.

    For flake8 or pylint, try the Ruff extension, it has support for linting, and formatting via the ruff library which supports flake8, pylint rules, and uses black rules for formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions