Skip to content

Figure out way to let jupyter query pylance for its list of completions #19129

Closed
Closed
Figure out way to let jupyter query pylance for its list of completions#19129
Labels
area-intellisenseLSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc.feature-requestRequest for new features or functionalitypartner ask

Description

@rchiodo
Rich Chiodo (rchiodo)
opened on May 11, 2022

I just thought of something. This whole thing is going to break de-duplication that we do for completions we get back from the jupyter kernel.

Right now, since the jupyter extension creates its own pylance, we can get the completions from pylance and remove those from jupyter that are the same thing.

After this change, the pylance server won't be started by jupyter and we won't be able to ask it directly for completions.

We need some way to find the specific completion provider (or the language client). So I think we'd need yet another API to pass the language client through to jupyter.

We could do that after this though.

This is the line where we ask pylance directly for its completions:
https://github.com/microsoft/vscode-jupyter/blob/8f7f38e2bc664836af236e8e2ad9f1b85130c3c9/src/intellisense/pythonKernelCompletionProvider.node.ts#L222

We'd need some way to get to this language client from jupyter still (well unless VS code has an API to return a specific completion provider but I don't think it does).

Originally posted by Rich Chiodo (@rchiodo) in #19087 (comment)

Activity

  1. github-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on May 11, 2022

  2. rchiodo commented on May 11, 2022

    @rchiodo
    Rich Chiodo (rchiodo)
    on May 11, 2022
    Author

    Once Python owning Pylance goes in, Jupyter can no longer get the list of completions from Pylance directly. Jupyter uses this to dedupe the results we get from the jupyter kernel.

    Ideas:

    • Query vscode for them but set a recursion flag in jupyter to ignore the request? This might work. Might be tricky to get the timing right as the request is async so not sure if it comes from jupyter or a legit request
    • Pass the languageclient to the jupyter extension so it can query pylance directly (or jedi for that matter). Downside here is the version of the languageclient has to be in sync.
    • Pass something smaller - just a method to use for querying completions. Method should be able to use just vscode types so easier to keep in sync.
  3. Karthik Nadig (karthiknadig)
    added
    feature-requestRequest for new features or functionality
    area-intellisenseLSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc.
    needs proposalNeed to make some design decisions
    partner ask
    and removed
    triage-neededNeeds assignment to the proper sub-team
    on May 12, 2022

  4. luabud commented on Dec 14, 2023

    @luabud
    Luciana Abud (luabud)
    on Dec 14, 2023
    Member

    There was a change made in Pylance to handle this for notebooks so closing this.

  5. Luciana Abud (luabud)
    closed this as completedon Dec 14, 2023
  6. github-actions
    removed
    needs proposalNeed to make some design decisions
    on Dec 14, 2023
  7. github-actions
    locked as resolved and limited conversation to collaborators on Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-intellisenseLSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc.feature-requestRequest for new features or functionalitypartner ask

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions