Skip to content

Restart Pylance without reload prompt once it is detected #18509

Closed

Description

@kieferrm

This shows the experience when creating a sample python dev container: https://cln.sh/KBwsUa (wait to the end of the recording...)

That I need to reload the window is not what I'd expect from a sample dev container (or in general). Since the Python extension activates on the existence of requirements.txt (see here) the language server change listener (see here is active.

It's unclear to why we need to reload the window if there is no open file at all. Also, we should make an effort to not require a reload. For example, the TS extension can recover from language server crashes/restarts without any reload.

Activity

  1. kieferrm commented on Feb 11, 2022

    @kieferrm
    MemberAuthor

    There is an additional issue here: If the container build process runs a bit longer after the extensions load and the user has pushed the progress notification into the background, the container configuration process from the user's point of view seems to hang forever

    image

    ...until the user clicks on the status bar item and sees the modal notification:

    image

  2. karthiknadig commented on Feb 14, 2022

    @karthiknadig
    Member
  3. added
    bugIssue identified by VS Code Team member as probable bug
    and removed
    triage-neededNeeds assignment to the proper sub-team
    on Feb 14, 2022
  4. changed the title [-]Reloading window when pylance is detected[/-] [+]Restart Pylance without reload prompt once it is detected[/+] on Feb 22, 2022
  5. removed their assignment
    on Feb 22, 2022
  6. added
    importantIssue identified as high-priority
    and removed
    investigatingWe are looking into the cause of the issue
    on Feb 22, 2022
  7. karrtikr commented on Feb 22, 2022

    @karrtikr

    With the current way the dependency injection is set up, it's not very trivial but adding the ability to deactivate Jedi (default language server) should solve this.

    The additional issue does not seem to be related to the extension cc/ Karthik Nadig (@karthiknadig)

  8. alexanderluiscampino commented on Mar 1, 2022

    @alexanderluiscampino

    Throwing my hat in the ring. I have adevcontainer post create command that install my reqs (poetry install) and it takes some time. By the time it is done, the pylance reload window disappeared and nothing gets done. It's a non-starter, since I won't be able to reload the window, and if I do, same happens, cycle repeats itself.

    What is the purpose of this window reload upon installing pylance?

  9. rzhao271 commented on May 2, 2022

    @rzhao271

    Looks like one of the endgame queries forgot to exclude on-testplan items for bugs. I'll label this issue as verified just to kick it off the query.

  10. locked as resolved and limited conversation to collaborators on Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-editor-*User-facing catch-allbugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityon-testplanAdded to test planverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions