Localize strings on github.dev #17712

Activity

1. Kartik Raj (karrtikr)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   needs PR

   importantIssue identified as high-priorityIssue identified as high-priority

   area-internalLabel for non-user facing issuesLabel for non-user facing issues

   on Oct 12, 2021
2. github-actions

   added

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Oct 12, 2021
3. Kartik Raj (karrtikr)

   removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Oct 12, 2021
4. karrtikr commented on Oct 12, 2021

   

   Kartik Raj (karrtikr)

   on Oct 12, 2021

   Author

   More actions

   Converting the existing localize module to async is a problem as that means we cannot load any existing localized strings at module level in the extension. Two approaches:

   • Fix all localized constants in the extension to not be imported at module level.
   • Create a separate localization module for the browser case which used the VSCode API.

   If first approach seems to take a long time, we should be going with the second approach.
5. Kartik Raj (karrtikr)

   closed this as completedin #17711on Oct 13, 2021
6. Kartik Raj (karrtikr)

   self-assigned this

   on Oct 13, 2021
7. Kartik Raj (karrtikr)

   added this to the September 2021 Recovery milestone on Oct 13, 2021
8. github-actions

   locked as resolved and limited conversation to collaborators on Nov 30, 2021