Skip to content

Analyze current path and log invalid items as soon as extension loads #1698

Description

See here #342 (comment)

Existence of the ; or ;; characters in the Path variable are known to result in the failure of the extension to load. If the extension fails to load please modify your paths to remove these characters.

Related issues:

Activity

  1. DonJayamanne commented on Jun 15, 2018

    @DonJayamanne
    Author

    Brett Cannon (@brettcannon)

    • Currently I'm looking for paths that contain ;

    • Based on feed back in Extension host terminated unexpectedly #342, that what has caused issues.

    • However I will not be checking for the existence of individual paths. I'm on the fence on this, as performing this checks could significantly slow down the load times of the extension.

    If this is necessary we could have a flag that if turned on, will perform that check as well.
    I.e. if extension fails to load, the user could turn on a setting (something similar to dump all diagnostics messages), causing the extension to be more strict with the checks.

  2. brettcannon commented on Jun 15, 2018

    @brettcannon
    Member

    Didn't we have another issue where things didn't work if a path entry didn't exist?

  3. DonJayamanne commented on Jun 15, 2018

    @DonJayamanne
    Author

    Didn't we have another issue where things didn't work if a path entry didn't exist?

    I think yes, Let me check,

  4. DonJayamanne commented on Jun 15, 2018

    @DonJayamanne
    Author

    Didn't we have another issue where things didn't work if a path entry didn't exist?

    Couldn't find such an issue, proceeding without this check, should be easy to add that if necessary (on Monday). Will look through issues on Monday as well.

  5. DonJayamanne commented on Jun 15, 2018

    @DonJayamanne
    Author

    Message displayed:
    untitled

  6. brettcannon commented on Jun 15, 2018

    @brettcannon
    Member

    Don Jayamanne (@DonJayamanne) "the Python extension not to load" or "to not load"; missing the "to".

  7. added a commit that references this issue on Jun 18, 2018
    161534f
  8. added a commit that references this issue on Jun 19, 2018
    0c516ef
  9. locked as resolved and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue identified by VS Code Team member as probable bugdebtCode quality issuesimportantIssue identified as high-priority

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions