Skip to content

Improve display names of interpreters in the list and status bar #1351

Closed
#2616
#2540
Closed
Improve display names of interpreters in the list and status bar#1351
#2616
#2540
Assignees
DonJayamanne
Labels
debtCode quality issuesfeature-requestRequest for new features or functionalityimportantIssue identified as high-priority
Milestone
2018, week 38 - September Sprint 2

Description

@DonJayamanne
Don Jayamanne (DonJayamanne)
opened on Apr 9, 2018

The prefix 'packaged by conda-forge` should not be added to some of the interpreters.
As this belongs to the root interpreters

Brett Cannon (@brettcannon) Dan Taylor (@qubitron)
We'll need to go come up with a set of rules for the display names of:

  • Conda, virtual, venv, and other environments.

screen shot 2018-04-09 at 11 31 56 am

win

Activity

  1. Don Jayamanne (DonJayamanne)
    added
    needs PR
    debtCode quality issues
    needs decision
    feature-interpreter
    on Apr 9, 2018
  2. Don Jayamanne (DonJayamanne)
    self-assigned this
    on Apr 9, 2018

  3. DonJayamanne commented on Apr 28, 2018

    @DonJayamanne
    Don Jayamanne (DonJayamanne)
    on Apr 28, 2018
    Author

    The following is a WIP:

    Requirements:

    • Able to identify the type of environment (whether its conda, pipenv, etc)
    • Able to identify version of Python
    • Able to identify name of the environment (if its a virtual environment or similar)
    • Able to identify the name of the company/distro
    • Consistent across all platforms
    • Consider requirements of PEP 514

    TBD:

    • Do we care for the display of bitness information (should be easy to determine, using sys.maxsize)
    • Do we need to display the type of release (e.g. if its a RC, beta etc, something other than the final release).

    Propose Format

    CompanyName DisplayName (EnvironmentName EnvironmentType)

    Propose Sort order

    • Environment + display name
      E.g.:
    1. Anaconda Python 2.7.14 32Bit (base)
    2. Anaconda Python 2.7.14 32Bit (env-01)
    3. Anaconda Python 3.5.1 64Bit (env-02)
    4. Python 2.7.14 32Bit (v01 pipenv)
    5. Python 3.5.1 32Bit (v02 pipenv)
    6. Python 3.5.1 32Bit (v03 pipenv)
    7. Python 3.5.1 32Bit (v03 pyenv)
    8. Python 3.6.1 32Bit (v03 venv)
    9. Python 3.5.1 32Bit (myenv2 virtualenv)

    Where:

    • CompanyName is
      • The name of the company (on Windows this is retrieved from the registry PEP 514)
    • DisplayName is
      • On Windows, this should be retrieved from the registry PEP 514
      • Python Major.Minor.Micro 32/64bit (for all but conda environments and non Windows OS)
        E.g. Python 2.7.14 32bit Python 3.5.1 64bit
    • EnvironmentType: is one of the following
      • pipenv
      • pyenv
      • venv
      • virtualenv
        Note: conda is not included in the above list, as the company name (prefix) would be an implicit indicator of the fact that its a conda environment.
  4. Don Jayamanne (DonJayamanne)
    changed the title [-]Improve display names of interpreters[/-] [+]Improve display names of interpreters in the list and status bar[/+] on Apr 28, 2018
  5. Brett Cannon (brettcannon)
    removed
    needs decision
    on May 2, 2018
  6. Don Jayamanne (DonJayamanne)
    added
    needs decision
    on May 2, 2018

  7. DonJayamanne commented on May 2, 2018

    @DonJayamanne
    Don Jayamanne (DonJayamanne)
    on May 2, 2018
    Author

    Added needs decision, as Dan Taylor (@qubitron) is working on the display format.
    I'm currently working on laying the foundation work to make the above possible (i.e. ensure we have all necessary bits of information to build the display value).

  8. DonJayamanne commented on May 4, 2018

    @DonJayamanne
    Don Jayamanne (DonJayamanne)
    on May 4, 2018
    Author

    Agreed display is as follows:
    Sort order = Version number

    Anaconda Python 2.7.14 32-bit (base)
Anaconda Python 2.7.14 32-bit (env-01)
Anaconda Python 3.5.1 64-bit (env-02)
Python 2.7.14 32-bit (v01 pipenv)
Python 3.5.1 32-bit (v02 pipenv)
Python 3.5.1 32-bit (v03 pipenv)
Python 3.5.1 32-bit (v03 pyenv)
Python 3.6.1 32-bit (v03 venv)
Python 3.5.1 32-bit (myenv2 virtualenv)
  9. Don Jayamanne (DonJayamanne)
    removed
    needs decision
    on May 4, 2018

  10. brettcannon commented on May 7, 2018

    @brettcannon
    Brett Cannon (brettcannon)
    on May 7, 2018
    Member

    What are the parts of (v03 venv)? Is that directory name and type? Should we separate those out more clearly as that will get confusing when the directory has a space, e.g. (some bunk venv)?

    And do we want x86/x64 instead of 32-bit/64-bit for any reason other than it's shorter? 😉

  11. DonJayamanne commented on May 7, 2018

    @DonJayamanne
    Don Jayamanne (DonJayamanne)
    on May 7, 2018
    Author

    (v03 venv)

    v03 - environment name
    venv - tool used to create environment (or environment type).

    confusing when the directory has a space, e.g. (some bunk venv)?

    Agreed. How about using double quotes when necessary?

    And do we want x86/x64

    Good idea. I went with the later as that's what is returned by python (when using --version).

  12. brettcannon commented on May 7, 2018

    @brettcannon
    Brett Cannon (brettcannon)
    on May 7, 2018
    Member

    Maybe ("some bunk" / venv)? ("some bunk": venv)?

  13. 24 remaining items

  14. Don Jayamanne (DonJayamanne)
    added a commit that references this issue on Sep 18, 2018

    Get pyenv root directory from central location (#2619)

    8c1661f

  15. ericsnowcurrently commented on Sep 19, 2018

    @ericsnowcurrently
    Eric Snow (ericsnowcurrently)
    on Sep 19, 2018

    Things look good now. "System" interpreters are shown correctly and pyenv showed up right.

  16. Eric Snow (ericsnowcurrently)
    closed this as completedon Sep 19, 2018
  17. Brett Cannon (brettcannon)
    reopened this on Sep 19, 2018
  18. Brett Cannon (brettcannon)
    removed
    validate fix
    needs PR
    on Sep 19, 2018

  19. d3r3kk commented on Sep 19, 2018

    @d3r3kk
    Derek Keeler (d3r3kk)
    on Sep 19, 2018

    (Tested as well, looks great)

  20. qubitron commented on Sep 19, 2018

    @qubitron
    Dan Taylor (qubitron)
    on Sep 19, 2018

    Looks good with the following changes:

    • virtualEnv -> virtualenv
    • venv space -> 'venv space'
  21. Brett Cannon (brettcannon)
    modified the milestones: 2018, week 36 - September 2018 Sprint 1, 2018, week 38 - September Sprint 2 on Sep 20, 2018
  22. Brett Cannon (brettcannon)
    added
    validate fix
    on Sep 24, 2018
  23. Don Jayamanne (DonJayamanne)
    added a commit that references this issue on Sep 24, 2018

    Minor UI changes to the display names of the interpreters (#2643)

    e7f7aed
  24. Brett Cannon (brettcannon)
    removed
    validate fix
    on Sep 25, 2018
  25. Brett Cannon (brettcannon)
    closed this as completedon Sep 25, 2018
  26. lock
    locked as resolved and limited conversation to collaborators on Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

debtCode quality issuesfeature-requestRequest for new features or functionalityimportantIssue identified as high-priority

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions