Add logging throughout the extension #1131

Activity

1. Brett Cannon (brettcannon)

   added

   needs PR

   debtCode quality issuesCode quality issues

   feature-extension

   on Mar 20, 2018
2. Brett Cannon (brettcannon)

   changed the title [-]Add logging through the extension[/-] [+]Add logging throughout the extension[/+] on Apr 16, 2018
3. brettcannon commented on Apr 16, 2018

   

   Brett Cannon (brettcannon)

   on Apr 16, 2018

   MemberAuthor

   More actions

   Any place we execute something behind the scenes through a system call we should document, e.g. the command we use to discover tests, to run them, etc.
4. brettcannon commented on Sep 19, 2018

   

   Brett Cannon (brettcannon)

   on Sep 19, 2018

   MemberAuthor

   More actions

   Duplicate of #2156
5. Brett Cannon (brettcannon)

   marked this as a duplicate of Logging in Extension #2156 on Sep 19, 2018
6. Brett Cannon (brettcannon)

   closed this as completedon Sep 19, 2018
7. lock

   locked as resolved and limited conversation to collaborators on Oct 17, 2018
8. Brett Cannon (brettcannon)

   reopened this on Jun 17, 2019
9. Brett Cannon (brettcannon)

   added

   needs decision

   and removed

   needs PR

   on Jun 17, 2019
10. Luciana Abud (luabud)

    added

    needs PR

    and removed

    needs decision

    on Jun 18, 2019
11. Luciana Abud (luabud)

    added this to the 2019 - June Sprint 12 milestone on Jun 18, 2019
12. Don Jayamanne (DonJayamanne)

    assigned

    Kim-Adeline Miguel (kimadeline)

    on Jun 19, 2019
13. kimadeline commented on Jun 19, 2019

    

    Kim-Adeline Miguel (kimadeline)

    on Jun 19, 2019

    Last edited by kimadeline

    More actions

    Todo

    • log all extension commands being run behind the scenes in the Python output panel, except for testing (stays in its own testing window)
    • for every command being run, display

    > path/to/command -args -args2
    cwd: current/working/directory // optional line if there is no directory parameter passed to the logging function
    

    • make sure that the commands and their output are being logged in VSCode's devtools
    • Ensure errors logged in extension are not (via some config or ability to mock) logged during unit tests
    • check that it works for:
      • vcode single workspaces
      • vscode multi-folder workspaces
      • folders
      • single files

    Later/separate PR:

    • move language server logs to a separate LS channel (might be related to Add command to display the language server output panel #7459)
    • display a truncated output in the Python channel (to revisit)
14. Eric Snow (ericsnowcurrently)

    modified the milestones: 2019 - June Sprint 12, 2019 - June Sprint 13 on Jun 26, 2019
15. Don Jayamanne (DonJayamanne)

    assigned

    Eric Snow (ericsnowcurrently)

    on Jul 8, 2019
16. ericsnowcurrently commented on Jul 8, 2019

    

    Eric Snow (ericsnowcurrently)

    on Jul 8, 2019

    More actions

    I've verified that, using master, I now see commands logged in the "Python" output panel.
17. Eric Snow (ericsnowcurrently)

    closed this as completedon Jul 8, 2019
18. ghost removed

    needs PR

    on Jul 8, 2019
19. Eric Snow (ericsnowcurrently)

    removed their assignment

    on Jul 8, 2019