Repository navigation
The filed named arguments of Request class shoulb be JsonElement type . #744
Description
[provide a description of the issue]
acoording to https://microsoft.github.io/debug-adapter-protocol/specification
`A client or debug adapter initiated request.
interface Request extends ProtocolMessage {
type: 'request';
/**
- The command to execute.
*/
command: string;
/**
- Object containing arguments for the command.
*/
arguments?: any;
}
`
When argument isn't exist . It's an JsonNull bject .
When JsonNull exist. it's an JsonObject boject.
So The filed which named arguments of com.microsoft.java.debug.core.protocol.Messages.Request class shoulb be JsonElement type .
Activity
kuafuwang commentedon Jan 5, 2020
This is the log
2020-1-5 15:46:24 Error parsing message: com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonNull Expected a com.google.gson.JsonObject but was com.google.gson.JsonNull com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonNull at com.google.gson.internal.bind.TypeAdapters$35$1.read(TypeAdapters.java:896) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:129) at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:220) at com.google.gson.Gson.fromJson(Gson.java:888) at com.google.gson.Gson.fromJson(Gson.java:853) at com.google.gson.Gson.fromJson(Gson.java:802) at com.google.gson.Gson.fromJson(Gson.java:774) at com.microsoft.java.debug.core.protocol.JsonUtils.fromJson(JsonUtils.java:26) at com.microsoft.java.debug.core.protocol.AbstractProtocolServer.processData(AbstractProtocolServer.java:219) at com.microsoft.java.debug.core.protocol.AbstractProtocolServer.run(AbstractProtocolServer.java:98) at com.microsoft.java.debug.core.adapter.ProtocolServer.run(ProtocolServer.java:61) at com.microsoft.java.debug.plugin.internal.JavaDebugServer$2.run(JavaDebugServer.java:136) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)[-]The filed arguments of Request class shoulb be JsonElement type .[/-][+]The filed named arguments of Request class shoulb be JsonElement type .[/+]testforstephen commentedon Jan 10, 2020
I'm curious which request in VS Code Debug Adapter Protocol will send an empty arguments to the debugger?
kuafuwang commentedon Jan 10, 2020
interface ThreadsRequest extends Request { command:ThreadRequest didn’t need argument.and I find out it when I test Cppdap.
testforstephen commentedon Jan 13, 2020
Here is the threads request from VS Code client:
[request]
{"command":"threads","type":"request","seq":34}
It doesn't contain arguments, the Java debugger can handle it well. I didn't see any exception occurs.
kuafuwang commentedon Jan 14, 2020
It's a bug in cppdap ,I had report the bug to the cppdap,and they alreader fixed it. But when it look up into your code . I just think it's better to using JsonElement type .