Skip to content

Add support for alpha versions - #132

Closed
TechoMan wants to merge 1 commit into
microsoft:developfrom
TechoMan:patch-1
Closed

TechoMan wants to merge 1 commit into
microsoft:developfrom
TechoMan:patch-1

Conversation

@TechoMan

@TechoMan TechoMan commented Dec 16, 2018 •

Copy link
Copy Markdown

This PR shouldn't break any of existing features.

Example of version that is considered Invalid: 2019.1.0a10
Example of download link: https://unity3d.com/unity/alpha/2019.1.0a10
Example of exception that this PR should fix:

Exception setting "Version": "Cannot convert value "2019.1.0a10" to type "UnityVersion". Error: "Invalid unity version: 2019.1.0a10""
At C:\Users\Artem\Documents\WindowsPowerShell\Modules\UnitySetup\4.0.97\UnitySetup.psm1:128 char:9
+         $this.Version = $fileVersion
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], SetValueInvocationException
    + FullyQualifiedErrorId : ExceptionWhenSetting

This shouldn't break any of existing features

@jwittner Josh Wittner (jwittner) left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change! Thanks for pushing for more versions to be available through UnitySetup! =)

This change doesn't seem to be enough as it fails to find any components for the version you mention. There are several places that will need the 'a' added to 'fbp', and it looks like the link to the core component for alpha versions doesn't match the UnitySetup64-$version.exe naming scheme of the other download types.

@StephenHodgson

Copy link
Copy Markdown
Contributor

Any update to this?

@StephenHodgson

Copy link
Copy Markdown
Contributor

We can probably close this now, correct?

@StephenHodgson

Copy link
Copy Markdown
Contributor

Josh Wittner (@jwittner) I think we can close this, I'm pretty sure the changes were superseded by #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants