Repository navigation
Enables support on macOS for Find-UnitySetupInstaller. - #123
Merged
Merged
Conversation
Member
Author
|
Verified on Windows 10 in PowerShell Core 6 and Windows PowerShell. |
Member
Author
|
Merged in latest from Microsoft/unitysetup.powershell to verify WebClient will work with macOS. |
Member
Author
|
Windows 10: PS Core 6 |
Member
Author
|
Windows 10: Windows PowerShell |
Member
Author
|
macOS 10.13.6: PS Core 6 |
Member
|
Robert Onulak (@Ziugy) If I understand correctly this should be closed in lieu of #126 ? |
Member
Author
|
Josh Wittner (@jwittner) However you want to handle this. This could go in first since it's independent from the install support PR. Would also focus the install PR specifically on that. |
Josh Wittner (jwittner)
left a comment
Member
There was a problem hiding this comment.
Looks awesome, thanks for the rich test dumps!
Josh Wittner (jwittner)
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start-BitsTransferis unavailable on macOS. Most likely need to convert to usingWebClientwhen Bits doesn't exist.