Repository navigation
Bugfix: Update mpirun options for Open MPI 5 compatibility - #896
Open
WenqingLan1 wants to merge 1 commit into
Open
WenqingLan1 wants to merge 1 commit into
WenqingLan1 wants to merge 1 commit into
Conversation
…lity Open MPI 5 (PRRTE-based mpirun) no longer accepts single-dash long options such as -bind-to and -map-by; e.g. "-bind-to numa" makes prterun treat "numa" as the executable. Switch the mpi mode command to the canonical --tag-output, --allow-run-as-root, --host, --hostfile, --map-by, --bind-to and --mca spellings, which Open MPI 4.x also accepts. -x is a real short option and is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain in the MPI option-spelling changes and corresponding test expectations.
No open issues 🎉
What changed in this PR
Updates MPI-mode command generation to use canonical long-option spellings for Open MPI 5 compatibility while retaining compatibility with Open MPI 4.x.
Changes:
- Replaces single-dash long options with double-dash forms, leaving
-xunchanged. - Updates command expectations in runner tests for hostfile, localhost, explicit hosts, and MCA options.
| File | Description |
|---|---|
tests/runner/test_runner.py |
Updates expected MPI commands to use double-dash long options. |
superbench/runner/runner.py |
Uses canonical long options when constructing MPI-mode commands. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 107 107
Lines 8258 8258
=======================================
Hits 7132 7132
Misses 1126 1126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open MPI 5 (PRRTE-based mpirun) no longer accepts single-dash long options such as
-bind-toand-map-by; e.g."-bind-to numa"makes prterun treat "numa" as the executable. Switch the mpi mode command to the canonical--tag-output,--allow-run-as-root,--host,--hostfile,--map-by,--bind-toand--mcaspellings, which Open MPI 4.x also accepts. -x is a real short option and unchanged.