Support ESLint 8.x #2890

Activity

1. iclanton commented on Sep 7, 2021

   

   Ian Clanton-Thuon (iclanton)

   on Sep 7, 2021

   Member

   More actions

   Pete Gonzalez (@octogonz) - want to take a look at this?
2. octogonz commented on Sep 10, 2021

   

   Pete Gonzalez (octogonz)

   on Sep 10, 2021

   Collaborator

   More actions

   We don't normally adopt or support beta versions of tools (since it's already a nontrivial time investment to keep up with officially released versions 😇).

   I'm fine however if someone wants to make a PR that enables usage of eslint-v8.0.0-beta-*. Heft should probably print a notice to the console saying it's not officially supported.

   I'm also curious to see what will happen with @rushstack/eslint-patch.
3. Pete Gonzalez (octogonz)

   added

   enhancementThe issue is asking for a new feature or design changeThe issue is asking for a new feature or design change

   help wantedIf you're looking to contribute, this issue is a good place to start!If you're looking to contribute, this issue is a good place to start!

   on Sep 10, 2021
4. Michaël De Boey (MichaelDeBoey)

   changed the title [-][eslint-config] Support ESLint 8.x[/-] [+]Support ESLint 8.x[/+] on Sep 10, 2021
5. lukashass commented on Oct 10, 2021

   

   Lukas (lukashass)

   on Oct 10, 2021

   Contributor

   More actions

   ESLint 8.0.0 was just released 😉 https://eslint.org/blog/2021/10/eslint-v8.0.0-released

   👍React with 👍6Reacted by Michaël De Boey, Sabertaz, Alistair Smith, Reagan Elm, Douglas Harcourt Parsons and intrnl

   🚀React with 🚀1Reacted by Pete Gonzalez
6. kodiakhq

   added a commit that references this issue on Oct 12, 2021

   Pin create-next-app to eslint@v7 (#29837)

   ...

   c78d8fa
7. anonrig commented on Oct 12, 2021

   

   Yagiz Nizipli (anonrig)

   on Oct 12, 2021

   More actions

   Any updates or news from this issue?
8. Ian Clanton-Thuon (iclanton)

   closed this as completedin #2965on Oct 13, 2021
9. marcoreni commented on Oct 26, 2021

   

   Marco Reni (marcoreni)

   on Oct 26, 2021

   Last edited by marcoreni

   More actions

   Ian Clanton-Thuon (@iclanton) I think this should be reopened since #2965 only solved issues for eslint-patch package.

   👍React with 👍1Reacted by Lukas
10. D4N14L commented on Nov 29, 2021

    

    Daniel (D4N14L)

    on Nov 29, 2021

    Contributor

    More actions

    Marco Reni (@marcoreni) is correct, this should be re-opened. I will take a look at this soon.
11. Daniel (D4N14L)

    reopened this on Nov 29, 2021
12. lukashass commented on Nov 30, 2021

    

    Lukas (lukashass)

    on Nov 30, 2021

    Contributor

    More actions

    Daniel (@D4N14L) FYI I already started this in #3009. Not sure if that covers everything needed to close this issue. Also, it is blocked by upstream changes as far as I can tell, but feel free to continue.
13. D4N14L commented on Dec 1, 2021

    

    Daniel (D4N14L)

    on Dec 1, 2021

    Contributor

    More actions

    Lukas (@lukashass) yes, I noticed this just recently, sorry for missing that! I already had some additional changes in my branch, so I'll likely create a separate PR for it. I'll tag you when I get that out.
14. Ian Clanton-Thuon (iclanton)

    closed this as completedin #3057on Dec 6, 2021
15. stefaneg commented on Jan 24, 2022

    

    Guðlaugur Stefán Egilsson (stefaneg)

    on Jan 24, 2022

    More actions

    I am working on getting eslint to work with heft, having trouble making it work with eslint 8.7.0.

    Is it possible that the documentation is out of date here?

    https://www.npmjs.com/package/@rushstack/eslint-config
16. D4N14L commented on Jan 24, 2022

    

    Daniel (D4N14L)

    on Jan 24, 2022

    Contributor

    More actions

    Guðlaugur Stefán Egilsson (@stefaneg) it seems like it works successfully (see this PR: #3185). What is the issue you're having?
17. stefaneg commented on Jan 24, 2022

    

    Guðlaugur Stefán Egilsson (stefaneg)

    on Jan 24, 2022

    More actions

    The error I get is this when execute heft build with .eslintrc.js exactly as it specified in the documentation. I have verified that everything is present in node_modules at the correct paths.

    > heft build 
    Project build folder is "/Users/gulli/src/github.com/rush-example/libraries/logging"
    Starting build
     ---- Pre-compile started ----
     ---- Pre-compile finished (1ms) ----
     ---- Compile started ----
    [typescript] Using TypeScript version 3.9.10
    [eslint] Using ESLint version 8.7.0
     ---- Compile encountered an error (2239ms) ----
    -------------------- Finished (2.51s) --------------------
    Project: @tm.is/logging@3.6.10
    Heft version: 0.44.2
    Node version: v16.13.1
    Error: Cannot read config file: /Users/gulli/src/github.com/rush-example/libraries/logging/.eslintrc.js
    Error: Failed to patch ESLint because the calling module was not recognized
    

    I tried downgrading ESLint to 7.32.0, and the error persists, so the issue seems to be something else.
18. stefaneg commented on Jan 24, 2022

    

    Guðlaugur Stefán Egilsson (stefaneg)

    on Jan 24, 2022

    Last edited by stefaneg

    More actions

    It looks like the message is originating here:

    rushstack/eslint/eslint-patch/src/modern-module-resolution.ts

    Line 158 in 0177df0

    'Failed to patch ESLint because the calling module was not recognized.\n' +

    Hard to be sure unless there is an output processor that outputs only the first line of the exception message to stderr.

    EDIT:

    Turned out that I managed somehow to install an old version of @rushstack/eslint-config which led to those obscure errors.

    👍React with 👍1Reacted by Daniel
19. Luighi Viton-Zorrilla (LuighiV)

    added a commit that references this issue on Aug 24, 2022

    Pin create-next-app to eslint@v7 (#29837)

    ...

    3702f4f
20. Ian Clanton-Thuon (iclanton)

    added this to Bug Triageon Aug 15, 2023
21. Ian Clanton-Thuon (iclanton)

    moved this to Closed in Bug Triageon Aug 15, 2023