Skip to content

Remove a stale ref to a deprecated file (UIWebView) - #259

Merged
HeyImChris merged 4 commits into
masterfrom
chrishog/webviewStaleRemoval
Mar 10, 2020
Merged

HeyImChris merged 4 commits into
masterfrom
chrishog/webviewStaleRemoval

Conversation

@HeyImChris

@HeyImChris HeyImChris commented Mar 9, 2020 •

Copy link
Copy Markdown

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • [X ] I am making a change required for Microsoft usage of react-native

Apple has a hard deadline of Dec 2020 for all apps to ship without UIWebview. It's been deprecated for a while now, but in our December 2019 release, Apple warned us against using it.

Although we aren't using it, I found a stale ref to a file that doesn't exist in the pbxproj which matches the file in the libReact.a in our internal builds.

Anyone building with pods (read: >=0.61) won't have this problem.

Focus areas to test

I printed the contents of libReact.a and it doesn't contain UIWebView.
(optional)

Microsoft Reviewers: Open in CodeFlow

@HeyImChris
HeyImChris merged commit 65f2bca into master Mar 10, 2020
@acoates-ms
acoates-ms deleted the chrishog/webviewStaleRemoval branch April 22, 2020 17:48
Christoph Purrer (christophpurrer) pushed a commit to christophpurrer/react-native-macos that referenced this pull request Aug 13, 2026
Summary:
Pull Request resolved: react#57954

Changelog: [Internal] - Update `react-native/debugger-frontend` from 571dc30...dbc1c52

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](react/react-native-devtools-frontend@571dc30...dbc1c52).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [dbc1c525f](react/react-native-devtools-frontend@dbc1c525f) | Alex Hunt (hello@alexhunt.dev) | 2026-08-13T17:58:45+01:00 | [Enable "Capture screenshot" command for React Native targets (microsoft#252)](react/react-native-devtools-frontend@dbc1c525f) |
| [e06f16d4e](react/react-native-devtools-frontend@e06f16d4e) | Nicola Corti (corti.nico@gmail.com) | 2026-06-10T14:11:47+01:00 | [Bump remaining vulnerable dev dependencies (microsoft#260)](react/react-native-devtools-frontend@e06f16d4e) |
| [950f4a8e3](react/react-native-devtools-frontend@950f4a8e3) | Nicola Corti (corti.nico@gmail.com) | 2026-06-04T14:46:30+01:00 | [Bump vulnerable dev dependencies (microsoft#259)](react/react-native-devtools-frontend@950f4a8e3) |
| [af53aca17](react/react-native-devtools-frontend@af53aca17) | Alex Hunt (hello@alexhunt.dev) | 2026-04-20T15:00:21+01:00 | [Disable inapplicable commands for React Native targets (microsoft#251)](react/react-native-devtools-frontend@af53aca17) |

Reviewed By: hoxyq

Differential Revision: D115891642

fbshipit-source-id: fcf1353aa4a4f45fe246fbc1ac6afa6837213ae1
Thiago Vinhas (tvinhas) pushed a commit to tvinhas/react-native-macos that referenced this pull request Oct 21, 2026
Summary:
Pull Request resolved: react#57954

Changelog: [Internal] - Update `react-native/debugger-frontend` from 571dc30...dbc1c52

Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](react/react-native-devtools-frontend@571dc30...dbc1c52).

### Changelog

| Commit | Author | Date/Time | Subject |
| ------ | ------ | --------- | ------- |
| [dbc1c525f](react/react-native-devtools-frontend@dbc1c525f) | Alex Hunt (hello@alexhunt.dev) | 2026-08-13T17:58:45+01:00 | [Enable "Capture screenshot" command for React Native targets (microsoft#252)](react/react-native-devtools-frontend@dbc1c525f) |
| [e06f16d4e](react/react-native-devtools-frontend@e06f16d4e) | Nicola Corti (corti.nico@gmail.com) | 2026-06-10T14:11:47+01:00 | [Bump remaining vulnerable dev dependencies (microsoft#260)](react/react-native-devtools-frontend@e06f16d4e) |
| [950f4a8e3](react/react-native-devtools-frontend@950f4a8e3) | Nicola Corti (corti.nico@gmail.com) | 2026-06-04T14:46:30+01:00 | [Bump vulnerable dev dependencies (microsoft#259)](react/react-native-devtools-frontend@950f4a8e3) |
| [af53aca17](react/react-native-devtools-frontend@af53aca17) | Alex Hunt (hello@alexhunt.dev) | 2026-04-20T15:00:21+01:00 | [Disable inapplicable commands for React Native targets (microsoft#251)](react/react-native-devtools-frontend@af53aca17) |

Reviewed By: hoxyq

Differential Revision: D115891642

fbshipit-source-id: fcf1353aa4a4f45fe246fbc1ac6afa6837213ae1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants