Repository navigation
Trying to use dynamic color causes an unhandled JS exception #413
Description
Environment
"react-native": "0.62.2",
"react-native-macos": "^0.61.37"
node v14.2.0
yarn 1.22.0
Xcode 11.5
Build version 11E608c
Issue
I was trying to use dynamic colors in my app, ex:
icon: {
color: {
dynamic: {
light: `black`,
dark: `white`,
},
},
},
when saving the file, I got a runtime exception:
Unhandled JS Exception: TypeError: undefined is not an object (evaluating '_reactNative.Appareance.getColorScheme')
I'm guessing this functionality is not implemented yet?
#335 might be related to this issue
(Write your steps here:)
- Try to use dynamic colors
Expected Behavior
No crash, actually be able to use colors based on current OS setting
Actual Behavior
Activity
tom-un commentedon May 24, 2020
Hi! The
{dynamic: {light: '', dark: ''} }color value type does work. However, the feature was added in this fork back in version 0.59. Its probable that after merging in .60 and .61 that new color values were added and we failed to refactor them to use the new ColorValue type.Which
colorprop exactly do you want to use the dynamic color on? It should not be a problem to add it.Also, this won't be an on going issue after we merge in react-native 0.63 because I contributed the mechanism upstream as the
PlatformColorAPI react#27908. So after we're in sync with .63, we will no longer be broken by new color props being added upstream.ospfranco commentedon May 26, 2020
Just a background color of a view, if it won't be an issue you can close this ticket and I will test it when new version is out
ospfranco commentedon May 30, 2020
I just tested again, and I must have made an error somewhere because the dynamic notation is working fine, sorry for any confusion