Repository navigation
Remove custom dialog - #117
Geoffrey Goh (geof90) wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Just a note that this file change is auto-generated from running the react-native upgrade command.
|
LGTM! |
|
LGTM, but I'd like to address the few bugs we have logged before making a change in RN version dependency. |
|
Since this is simply a code-cleanup PR, which doesn't add any new features, but does represent a breaking change, I think we should wait to merge this along with adding assets support for Android, since that will require a new version of React Native as well. If your PR gets merged in time for 0.18.0, then I think it would be great to release a new minor release of the plugin that depends on that RN version, and adds in Android asset support and removes our dialog implementation at the same time. |
|
Closed because of issues with the RN Alert being unable to support our scenario, such as it being dismissable when the user touches the outside of the dialog. |
This PR upgrades to RN 0.17.0, and in so doing, removes our custom dialog module implementation since the OOTB RN Alert module is now cross platform.
Fixed a minor bug with tests, the remotePackage for InstallUpdateTests was exported under the "default" property and not directly as the exported object itself.