This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Resource-ify diagnostic messages, rename some codes, remove "(...)" - #324
Merged
Jake Bailey (jakebailey) merged 2 commits intoOct 30, 2018
Merged
Jake Bailey (jakebailey) merged 2 commits into
Jake Bailey (jakebailey) merged 2 commits into
Conversation
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
Oct 30, 2018
Jake Bailey (jakebailey)
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…icrosoft#324) Closes microsoft#299. (Specifically the naming part in the comments.) Strings have been moved into Resources. `(parser)` and `(analysis)` have been removed from the diagnostic source strings. I also renamed one of the codes to be more representative of what it actually means (while we have the ability to change something like this without breaking users). The tests I modified in LanguageServerTests are not well-written (hardcoded strings rather than a table of actual things to compare), but I just made them pass for now and could fix them later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #299. (Specifically the naming part in the comments.)
Strings have been moved into Resources.
(parser)and(analysis)have been removed from the diagnostic source strings. I also renamed one of the codes to be more representative of what it actually means (while we have the ability to change something like this without breaking users).The tests I modified in LanguageServerTests are not well-written (hardcoded strings rather than a table of actual things to compare), but I just made them pass for now and could fix them later.