Repository navigation
Allow navigation to stubs - #1960
Mikhail Arkhipov (MikhailArkhipov) merged 42 commits into
Conversation
This reverts commit 6109ac7.
|
Does this need a test for the linked issue? I'm surprised |
|
It is in |
|
The original issue was not on Windows, so hopefully the same behavior occurs there too. |
|
This appears to break the UpdateReferencesOnEdit test. |
|
Specifically, the first |
|
Fixed, unintentional change. |
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
There was a problem hiding this comment.
LGTM, passes tests now. Would be good to look into jumping to scraper stubs in the future, but this fixes a few things.
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Allow navigation to stubs * Better handle stubs for compiled modules * Fix typeshed path * Partial undo * Partial undo * Undo accidental change
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Allow navigation to stubs * Better handle stubs for compiled modules * Fix typeshed path * Partial undo * Partial undo * Undo accidental change
No harm in showing stub for compiled code or when otherwise source is not available. Also fixes issue when documentation on
osparts was not transferred sincentorposixare not submodules ofos.Closes #1921