Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Ensure builtins module is created synchronously - #1798

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 22 commits into
microsoft:masterfrom
MikhailArkhipov:b1697
Nov 16, 2019
Merged

Mikhail Arkhipov (MikhailArkhipov) merged 22 commits into
microsoft:masterfrom
MikhailArkhipov:b1697

Conversation

@MikhailArkhipov

@MikhailArkhipov Mikhail Arkhipov (MikhailArkhipov) commented Nov 15, 2019 •

Copy link
Copy Markdown

For #1697

MikhailArkhipov added 22 commits September 30, 2019 12:03
@jakebailey

Copy link
Copy Markdown
Member

A few caching tests fail, weird.

@MikhailArkhipov

Copy link
Copy Markdown
Author

Seems to be unrelated. Like inspect is looking for Attribute in typing while it is actually a named tuple in the inspect stub. I can look into that, but #1757 supersedes caching anyway.

@MikhailArkhipov

Copy link
Copy Markdown
Author

Combined with #1757 all pass

@MikhailArkhipov

Copy link
Copy Markdown
Author

Will leave #1697 open until confirmed.

Mikhail Arkhipov (MikhailArkhipov) pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference

* Don't suppress LHS diagnostics on augmented assign

* Revert "Don't suppress LHS diagnostics on augmented assign"

This reverts commit 6109ac7.

* Sync builtins creation

* Sync builtins

* Usings

* Debug code
Mikhail Arkhipov (MikhailArkhipov) pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference

* Don't suppress LHS diagnostics on augmented assign

* Revert "Don't suppress LHS diagnostics on augmented assign"

This reverts commit 6109ac7.

* Sync builtins creation

* Sync builtins

* Usings

* Debug code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants