Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Fix fetching members from bases - #1742

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 15 commits into
microsoft:masterfrom
MikhailArkhipov:b1741
Nov 4, 2019
Merged

Mikhail Arkhipov (MikhailArkhipov) merged 15 commits into
microsoft:masterfrom
MikhailArkhipov:b1741

Conversation

@MikhailArkhipov

Copy link
Copy Markdown

Fixes #1741

Comment thread src/Analysis/Ast/Impl/Types/PythonClassType.cs
@jakebailey

Copy link
Copy Markdown
Member

Can you merge master so I can test this with some numpy stuff?

@jakebailey Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it in a local checkout with master merged. Looks good to me.

@MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) merged commit c4a5c9c into microsoft:master Nov 4, 2019
Mikhail Arkhipov (MikhailArkhipov) pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference

* Fix fetching ctor from bases

* Test fix

(cherry picked from commit c4a5c9c)
Mikhail Arkhipov (MikhailArkhipov) pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference

* Fix fetching ctor from bases

* Test fix

(cherry picked from commit c4a5c9c)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lightgbm parameters intellisence Unsupport

2 participants