PLS doesn't resolve relative paths correctly #510

Activity

1. Mikhail Arkhipov (MikhailArkhipov)

   assigned

   Alexander Sher (AlexanderSher)

   on Dec 26, 2018
2. Mikhail Arkhipov (MikhailArkhipov)

   added this to the Jan 2019.1 milestone on Dec 26, 2018
3. MikhailArkhipov commented on Dec 26, 2018

   

   Mikhail Arkhipov (MikhailArkhipov)

   on Dec 26, 2018

   More actions

   Alexander Sher (@AlexanderSher) owns the import subsystem.
4. AlexanderSher commented on Jan 2, 2019

   

   Alexander Sher (AlexanderSher)

   on Jan 2, 2019

   Last edited by AlexanderSher

   Contributor

   More actions

   I don't understand why this logic is needed.

   It is required for the case when there is a folder with the name of the module.
   For example, for the following file structure:

   ├─ package
      ├─ module
      │  └─ submodule.py
      ├─ module.py
      └─ test.py
   

   and test.py:

   from .module.submodule import TEST
   

   import should be highlighted as invalid import.

   In your case, what is the value of lastEdge.End.ModulePath in that piece of code?

   if (lastEdge.End.IsModule) {
       return false;
   }
5. erictraut commented on Jan 2, 2019

   

   Eric Traut (erictraut)

   on Jan 2, 2019

   Author

   More actions

   In the example you gave above, if the module directory contained an __init__.py file, the import from test.py should succeed. Would you expect lastEdge.End.IsModule to evaluate to false if __init__.py is present?

   To answer your question. lastEdge.End.IsModule evaluates to true in my case, which is what causes the .exceptions and '.image_builder` imports to be incorrectly flagged as errors.
6. Alexander Sher (AlexanderSher)

   added 2 commits that reference this issue on Jan 2, 2019

   - Fix microsoft#509: PLS doesn't flag error in a relative import if i…

   ...

   This issue will close once commit ab15e1e is merged into the 'master' branch.

   ab15e1e

   Two path resolution bug fixes

   ...

   This issue will close once commit 23f6d67 is merged into the 'master' branch.

   23f6d67
7. Alexander Sher (AlexanderSher)

   closed this as completedon Jan 2, 2019
8. Alexander Sher (AlexanderSher)

   added 2 commits that reference this issue on Feb 4, 2019

   Two path resolution bug fixes

   ...

   This issue will close once commit 00aebad is merged into the 'master' branch.

   00aebad

   Cherry pick fixes from Release branch into PTVS branch (#578)

   ...

   This issue will close once commit a5b6e5e is merged into the 'master' branch.

   a5b6e5e