PLS doesn't handle changes to python.autoComplete.extraPaths setting #507

Activity

1. Mikhail Arkhipov (MikhailArkhipov)

   assigned

   Alexander Sher (AlexanderSher)

   on Dec 27, 2018
2. Mikhail Arkhipov (MikhailArkhipov)

   added

   feature: imports

   bugSomething isn't workingSomething isn't working

   on Dec 27, 2018
3. AlexanderSher commented on Dec 31, 2018

   

   Alexander Sher (AlexanderSher)

   on Dec 31, 2018

   Contributor

   More actions

   LS receives extraPaths as part of PythonInitializationOptions.searchPaths when it is started. Mikhail Arkhipov (@MikhailArkhipov) , do you know if LS is restarted when this parameter is changed?
4. MikhailArkhipov commented on Jan 2, 2019

   

   Mikhail Arkhipov (MikhailArkhipov)

   on Jan 2, 2019

   Last edited by MikhailArkhipov

   More actions

   It didn't change AFAIK.
   https://github.com/Microsoft/vscode-python/blob/master/src/client/activation/languageServer/languageServer.ts#L246-253

           let searchPaths = interpreterData ? interpreterData.searchPaths.split(path.delimiter) : [];
           const settings = this.configuration.getSettings();
           if (settings.autoComplete) {
               const extraPaths = settings.autoComplete.extraPaths;
               if (extraPaths && extraPaths.length > 0) {
                   searchPaths.push(...extraPaths);
               }
           }

   However, change of configuration does not restart the LS and current implementation is not capable of handling the search path update without the restart. Restarting IDE is not necessary, there is 'Reload Window' command in VS Code.
5. Mikhail Arkhipov (MikhailArkhipov)

   removed

   bugSomething isn't workingSomething isn't working

   on Jan 2, 2019
6. DonJayamanne commented on Jan 3, 2019

   

   Don Jayamanne (DonJayamanne)

   on Jan 3, 2019

   More actions

   Is it not possible for the LS to react to changes to this setting if it was somehow propagated to LS.
   Ie can LS react to changes without having to restart the LS.
7. MikhailArkhipov commented on Jun 20, 2019

   

   Mikhail Arkhipov (MikhailArkhipov)

   on Jun 20, 2019

   More actions

   May be part of #1213
8. Mikhail Arkhipov (MikhailArkhipov)

   unassigned

   Alexander Sher (AlexanderSher)

   on Jun 20, 2019
9. jakebailey commented on Jul 10, 2019

   

   Jake Bailey (jakebailey)

   on Jul 10, 2019

   Member

   More actions

   With #1289 merged, this could now be possible. Paths are now resolved later at the first ReloadAsync, versus in the initialization. Since the extension has been starting the language server with PYTHONPATH set, we could stop accepting searchPaths in our initialization options, then do the combining of PYTHONPATH/extraPaths together ourselves. Doing this would allow us to redo that work when we see the config change.

   But we'd need to decide whether or not python.autoComplete.extraPaths is the actual configuration name we want to give this. I expect we want settings under python.analysis instead, with some more granularity to let people pick and choose which paths go where (instead of a big list).

   👍React with 👍1Reacted by Joe Antonakakis
10. Jma353 commented on Jul 12, 2019

    

    Joe Antonakakis (Jma353)

    on Jul 12, 2019

    More actions

    Moving away from searchPaths and towards config-driven extraPaths that reacts to changes in the config would be awesome!
11. jakebailey commented on Jul 25, 2019

    

    Jake Bailey (jakebailey)

    on Jul 25, 2019

    Member

    More actions

    I'm going to close this in favor of #1388. This should now be doable (as previously said). The setting name is likely to change, as it's a relic.
12. Jake Bailey (jakebailey)

    closed this as completedon Jul 25, 2019