You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
For the sake of writing it down, the plan is to add a new class to encapsulate "diagnostics" like undeclared variables, unknown imports, non-callables, etc, keep track of them in the analyzer, then later expose those with filtering, and past that, generate code actions from those diagnostics.
After going through everything, it turns out that PythonAnalyzer._diagnostics already basically encapsulates what we're looking for. There's already code in place for undeclared names and code for missing imports (with an associated message). It should just need some tweaking to better define when diagnostics are created and filtered.
Activity
MikhailArkhipov commentedon Oct 15, 2018
Adding sprint to we can start investigation since #19 needs this.
jakebailey commentedon Oct 16, 2018
For the sake of writing it down, the plan is to add a new class to encapsulate "diagnostics" like undeclared variables, unknown imports, non-callables, etc, keep track of them in the analyzer, then later expose those with filtering, and past that, generate code actions from those diagnostics.
jakebailey commentedon Oct 17, 2018
After going through everything, it turns out that
PythonAnalyzer._diagnosticsalready basically encapsulates what we're looking for. There's already code in place for undeclared names and code for missing imports (with an associated message). It should just need some tweaking to better define when diagnostics are created and filtered.jakebailey commentedon Oct 18, 2018
Only enable diagnostics and fix settings change detection (#298)
Only enable diagnostics and fix settings change detection (microsoft#298