Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Many (most?) files don't conform to the project's .editorconfig #2097

Open

Description

@leungbk

On Linux, with the Editorconfig plugin for Emacs enabled, whenever I make a change inside a .cs file contained in this project, I notice that I generate a lot of ^M characters (when before there were none) unless I set end_of_line = lf in the project's .editorconfig, which currently has end_of_line = crlf.

Based on the .editorconfig, I would have expected all the files to already have ^M characters terminating each line.

Activity

  1. jakebailey commented on Jul 1, 2020

    @jakebailey
    Member

    This seems like an interplay between git's choice of line endings and the config, where it's checking it out as LF, not CRLF. We've typically worked on Windows in VS, where git by default will use CRLF when pulling down (so VS would not perceive any problems with formatting).

    On Linux, it's likely checking it out as LF so the editorconfig is wrong. Arguably the config should just be removed; the tests normalize things or otherwise don't care about the encoding of their files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions