Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

future improvement on add import  #1721

Open

Description

this feature ("add import" - #1656) adds this extra cost to analysis

  1. cpu usage - indexing all library files installed once the language server started. it runs on BG so it doesn't interfere with user interactions but the user can see CPU burning while indexing happens.

  2. allocations - indexing all library files cause us to parse all those library files causing us to allocate memory we didn't allocate before. (ex, about 200MB spike in memory while processing)

  3. VM - we now hold index info on library files as well on top of user code index causing us to hold more in memory. (ex. about 90MB more for our testbed - anaconda + popular libraries)

...

we can improve each part as follow if we believe that is necessary.

for 1, add "persisted index" over libraries so that we only do indexing only once.
for 2, reduce allocations and add pooling.
for 3, compact index data memory footprint.

Activity

  1. changed the title [-]future improvement on add import (https://github.com/microsoft/python-language-server/pull/1656)[/-] [+]future improvement on add import [/+] on Oct 28, 2019
  2. heejaechang commented on Oct 28, 2019

    @heejaechang
    Author

    tagging Jude Kavalam (@judej) for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions