Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Failure analyzing decorator module, high CPU/RAM usage #1401

Closed
Closed
Failure analyzing decorator module, high CPU/RAM usage#1401
Assignees
CTrando
Labels
bugSomething isn't workingfeature: analysis
Milestone
August 2019.1

Description

@uriva
uriva
opened on Aug 2, 2019

Hi,

I have "python.jediEnabled": false in my settings.json.

Whenever I open a project, I see "analyzing in background" for a bit, then it stops. Usually it's 1200 targets or something similar.

Then from time to time I have a spike of cpu (200%) and ram usage from the process, and the code is again "analyzed in background".

This is coming from .vscode/extensions/ms-python.python-2019.6.24221/languageServer.0.3.43/Microsoft.Python.LanguageServer.

Over the last month the cpu/ram issues were on and off. At first they were making the computer stuck (I had to restart) and other times it went away after awhile. I saw some issues were opened and the closed, but over the last two weeks it again became hard to work with vscode because of this, so probably the problem isn't completely fixed.

Activity

  1. MikhailArkhipov commented on Aug 2, 2019

    @MikhailArkhipov
    Mikhail Arkhipov (MikhailArkhipov)
    on Aug 2, 2019

    Could you provide

    • Amount of RAM used (few hundred meg is not unusual)
    • List of packages you use beside system (i.e. tensorflow, numpy, plotly?)
    • How long CPU spike may last (LS is heavily multi-threaded so using multiple cores is normal unless it lasts for a long time).

  2. uriva commented on Aug 2, 2019

    @uriva
    uriva
    on Aug 2, 2019
    Author

    I can't easily reproduce, but an hour ago I edited some code and it seems to re-analyze on every code change, then the entire cpu was unresponsive and I had to power down, so it's more than a few hundred megs.

    Now by just opening the project and waiting for awhile, it reaches 6GB ram consumption.

    I think spacy and selenium are the heaviest dependencies I have (no tensorflow).

  3. uriva commented on Aug 2, 2019

    @uriva
    uriva
    on Aug 2, 2019
    Author

    Another thing that may be of interest is that I have two projects opened sometimes, and one depends on the other (pip install -e).

  4. uriva commented on Aug 2, 2019

    @uriva
    uriva
    on Aug 2, 2019
    Author

    I think the cpu is less of a worry than ram is (makes the mouse unusable).

  5. jakebailey commented on Aug 2, 2019

    @jakebailey
    Jake Bailey (jakebailey)
    on Aug 2, 2019
    Member

    If they depend on each other and you open them separately, then you'll have two language servers running watching both such that changing one causes the other to be reanalyzed. If that's happening often, then this may be the module reloading memory usage issue I'm currently working on.

  6. uriva commented on Aug 2, 2019

    @uriva
    uriva
    on Aug 2, 2019
    Author

    Now for example it's analyzing >5 minutes, and the computer intermittently freezes.

  7. uriva commented on Aug 2, 2019

    @uriva
    uriva
    on Aug 2, 2019
    Author

    Jake Bailey (@jakebailey) I think this is related, as it's aggravated when I'm working on the two projects at the same time, but it's not explaining the very long analysis even when there's no code change.

  8. uriva commented on Aug 8, 2019

    @uriva
    uriva
    on Aug 8, 2019
    Author

    I'm also using ipython with autoreload in case it matters.

  9. jakebailey commented on Aug 8, 2019

    @jakebailey
    Jake Bailey (jakebailey)
    on Aug 8, 2019
    Member

    Can you retest things with the latest version? 0.3.46 contains a memory fix to module reloading (and others), which appears to have restored things to as they were a few weeks ago.

  10. uriva commented on Aug 10, 2019

    @uriva
    uriva
    on Aug 10, 2019
    Author

    There's definitely an improvement, but still not as it was >2 month ago.

    Still any code change in the dependency project causes a spike in RAM (I measured 2GB now), and high cpu.

    This is tolerable, but I did manage to reach a state where again analysis never ends, but was not able to repro/measure ram, so will update once it happens again.

  11. uriva commented on Aug 10, 2019

    @uriva
    uriva
    on Aug 10, 2019
    Author

    Initial analysis ends pretty fast.

    Then, sadly after a few edits in the dependency project, analysis starts again and is stuck on the same number (e.g. 1000 items) infinitely. Ram is rising to 5.5g (+ 11g in virtual memory) and the computer becomes unresponsive.

  12. jakebailey commented on Aug 12, 2019

    @jakebailey
    Jake Bailey (jakebailey)
    on Aug 12, 2019
    Member

    I'd appreciate it if you enable trace logging and upload a copy of the language server logs when this happens. See here for some info: https://github.com/microsoft/python-language-server/blob/master/TROUBLESHOOTING.md#filing-an-issue

  13. uriva commented on Aug 13, 2019

    @uriva
    uriva
    on Aug 13, 2019
    Author

    okay (I did some small redactions for privacy) https://gist.github.com/uriva/a0f243c8b15a03c264afc6a2ae27a936

    Reproduction is just to do several changes across different files in the dependency project. Then it goes into infinite analysis in the other one. You can see that some lines are repeating thousands of times.

    This run never ends actually (>>10 minutes), the pc is "usable", but working very hard the entire time (as I said before, sometimes it is even worse, and the pc becomes unresponsive).

  14. jakebailey commented on Aug 13, 2019

    @jakebailey
    Jake Bailey (jakebailey)
    on Aug 13, 2019
    Member

    This looks similar to #1426, actually. I see decorator is failing. In the same environment, can you open a file that's just import decorator, and see if you see an exception come up when doing something like decorator. to trigger completion on the module?

  15. uriva commented on Aug 13, 2019

    @uriva
    uriva
    on Aug 13, 2019
    Author

    Seems to be working fine when writing decorator. suggestions come up normally.

  16. 2 remaining items

  17. jakebailey commented on Aug 14, 2019

    @jakebailey
    Jake Bailey (jakebailey)
    on Aug 14, 2019
    Member

    We just built a version which includes some more logging, v0.3.56. I'd appreciate it if you could set the following in your config and reload to trigger a download, then see if you can grab one of the stack traces for those exceptions.

    "python.analysis.downloadChannel": "daily"
  18. Jake Bailey (jakebailey)
    changed the title [-]CPU/RAM spikes[/-] [+]Failure analyzing decorator module, high CPU/RAM usage[/+] on Aug 14, 2019

  19. Coderx7 commented on Aug 15, 2019

    @Coderx7
    Seyyed Hossein Hasanpour (Coderx7)
    on Aug 15, 2019

    Here is my log after adding :
    "python.analysis.downloadChannel": "daily"
    log file

  20. jakebailey commented on Aug 15, 2019

    @jakebailey
    Jake Bailey (jakebailey)
    on Aug 15, 2019
    Member

    The relevent bits:

    Analysis of decorator(Library) failed. System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Python.Analysis.Analyzer.Symbols.FunctionEvaluator.Walk(ReturnStatement node) in E:\A\_work\3\s\src\Analysis\Ast\Impl\Analyzer\Symbols\FunctionEvaluator.cs:line 122
   at Microsoft.Python.Parsing.Ast.ReturnStatement.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\ReturnStatement.cs:line 34
   at Microsoft.Python.Parsing.Ast.SuiteStatement.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\SuiteStatement.cs:line 41
   at Microsoft.Python.Analysis.Analyzer.Symbols.FunctionEvaluator.Evaluate() in E:\A\_work\3\s\src\Analysis\Ast\Impl\Analyzer\Symbols\FunctionEvaluator.cs:line 64
   at Microsoft.Python.Analysis.Analyzer.Symbols.ModuleSymbolTable.Evaluate(ScopeStatement target) in E:\A\_work\3\s\src\Analysis\Ast\Impl\Analyzer\Symbols\ModuleSymbolTable.cs:line 87
   at Microsoft.Python.Analysis.Analyzer.ModuleWalker.Walk(FunctionDefinition node) in E:\A\_work\3\s\src\Analysis\Ast\Impl\Analyzer\ModuleWalker.cs:line 189
   at Microsoft.Python.Parsing.Ast.FunctionDefinition.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\FunctionDefinition.cs:line 197
   at Microsoft.Python.Parsing.Ast.SuiteStatement.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\SuiteStatement.cs:line 41
   at Microsoft.Python.Parsing.Ast.IfStatementTest.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\IfStatementTest.cs:line 41
   at Microsoft.Python.Parsing.Ast.IfStatement.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\IfStatement.cs:line 45
   at Microsoft.Python.Parsing.Ast.SuiteStatement.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\SuiteStatement.cs:line 41
   at Microsoft.Python.Parsing.Ast.PythonAst.Walk(PythonWalker walker) in E:\A\_work\3\s\src\Parsing\Impl\Ast\PythonAst.cs:line 81
   at Microsoft.Python.Analysis.Analyzer.PythonAnalyzerSession.AnalyzeEntry(IDependencyChainNode`1 node, PythonAnalyzerEntry entry, IPythonModule module, PythonAst ast, Int32 version) in E:\A\_work\3\s\src\Analysis\Ast\Impl\Analyzer\PythonAnalyzerSession.cs:line 326
   at Microsoft.Python.Analysis.Analyzer.PythonAnalyzerSession.Analyze(IDependencyChainNode`1 node, AsyncCountdownEvent ace, Stopwatch stopWatch) in E:\A\_work\3\s\src\Analysis\Ast\Impl\Analyzer\PythonAnalyzerSession.cs:line 264

    cc Cameron Trando (@CTrando)

  21. MikhailArkhipov commented on Aug 15, 2019

    @MikhailArkhipov
    Mikhail Arkhipov (MikhailArkhipov)
    on Aug 15, 2019

    Cameron Trando (@CTrando) - most probably FunctionDefinition.Name is null or _function.DeclaringType is null. Neither guaranteed to exist.

  22. Mikhail Arkhipov (MikhailArkhipov)
    closed this as completedon Aug 15, 2019
  23. Mikhail Arkhipov (MikhailArkhipov)
    reopened this on Aug 15, 2019
  24. Mikhail Arkhipov (MikhailArkhipov)
    assigned
    Cameron Trando (CTrando)
    on Aug 15, 2019
  25. Mikhail Arkhipov (MikhailArkhipov)
    added
    bugSomething isn't working
    feature: analysis
    on Aug 15, 2019
  26. Mikhail Arkhipov (MikhailArkhipov)
    added this to the August 2019.1 milestone on Aug 15, 2019

  27. cspwizard commented on Aug 20, 2019

    @cspwizard
    Konstantin Pozdniakov (cspwizard)
    on Aug 20, 2019

    Hi! Can you give an estimate when this issue will be fixed? Have similar issue on MS language server 0.3.47.0 it consumes ~6GB of ram (all available at that moment). The problem was caused by simply opening of https://github.com/marcospereirampj/python-keycloak repo clone

  28. MikhailArkhipov commented on Aug 20, 2019

    @MikhailArkhipov
    Mikhail Arkhipov (MikhailArkhipov)
    on Aug 20, 2019

    Konstantin Pozdniakov (@cspwizard) - this issue is specifcally about decorators and exception above. Your case may or may not be the same. Please open separate issue. 0.3.59 is now published, restart VSC to update. Thanks.

  29. MikhailArkhipov commented on Aug 21, 2019

    @MikhailArkhipov
    Mikhail Arkhipov (MikhailArkhipov)
    on Aug 21, 2019

    Exception is fixed in #1461 - 0.3.61

  30. Mikhail Arkhipov (MikhailArkhipov)
    closed this as completedon Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingfeature: analysis

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions