Repository navigation
torch.nn missing from torch module and from torch import completions #1301
Description
Hi,
I'm the author of type stubs for PyTorch, and it seems VSCode is not suggesting some autocompletes of methods and modules that the stubs clearly state exist and that mypy and PyCharm make use of (using the 'daily' download channel). I haven't been able to construct a MWE yet.
To reproduce, install PyTorch master (as of 046c4589df15fc4e7b832d594d3d8e3a54cd47c9) following the instructions at https://github.com/pytorch/pytorch#get-the-pytorch-source. NOT the release version, which doesn't yet ship with the type stubs the language server seems to be having trouble using.
In a buffer, after waiting for the analysis to complete, try
import torch
torch.the list of autocompletes does not include the nn module, even though from . import nn as nn appears in torch/__init__.pyi.
Further,
from torch import nn
nn.doesn't provide any suggestions from the language server, even though torch/nn/__init__.pyi contains
from .modules import *
from .parameter import Parameter as Parameter
from .parallel import DataParallel as DataParallel
from . import init as init
from . import utils as utils
Activity
[-]Autocomplete incorrect for pytorch master[/-][+]Autocomplete incomplete for pytorch master[/+]caidwang commentedon Aug 13, 2019
Meet the same problem.
malmaud commentedon Aug 13, 2019
The shipping version of PyTorch (1.2) contains the new type stubs that seem to be causing VSCode difficulty, so now a simple
pip install pytorchis all that's needed to reproduce this.jakebailey commentedon Aug 13, 2019
I can see that
nndoesn't exist when you try to dotorch.. It seems like thetorchmodule doesn't have the membernnat all, either in the module or the stub (in the analysis). The same goes forcudaandoptim, both of which are stubbed in the same way.Jonathan Malmaud (@malmaud) You might know better, but is there a reason why
from . import nn as nnis done, as opposed to just havingnn.pyiornn/__init__.pyin the stubs? I don't see why what is done now wouldn't work, just thinking of other options.FWIW, I installed in a fresh virtualenv via the instructions on the website (
pip install pytorchdoesn't work):malmaud commentedon Aug 13, 2019
Hmm, not quite sure I follow -
torch/nn/__init__.pyi(andtorch/nn/__init__.py) do exist. Given that, how else wouldtorch/__init__.pyiexpose thennsubmodule except with afrom . import nnstatement? I'm definitely open to changing the stubs if you see a problem with that design.The reason there isn't a single
nn.pyiis mainly just so the stub files can mirror the implementations - each implementation file has a corresponding stub, and there is nonn.py. Additionally thennmodule is quite large so I wouldn't want to stick its whole stub in a single file.Also FYI, no need to install
torchvisionto reproduce this, but you are right that it should have beenpip install torchinstead ofpip install pytorch(for some reason, the PyTorch conda package is calledpytorchso I got confused).jakebailey commentedon Aug 13, 2019
I meant not exposing nn through a member of the top level torch module; my expectation was that it'd still be importable as "torch.nn" or similar without torch's stub re-exporting it. This is just speculation, my expectation is also that what's written already should work.
pip installing "torch" didn't work either; it threw errors and tried to select some pre-v1.0 version.
malmaud commentedon Aug 13, 2019
Oh, I see.
I tested, and even if I delete the
from . import nn as nnline intorch/__init__.pyiand then in a new buffer trythe LS still doesn't provide suggestions.
MikhailArkhipov commentedon Sep 18, 2019
Conda, Python 3.7.
Now, in
nnis indeed missing while present inI will look into why. This is 0.4.20, available in
betachannel.5 remaining items
MikhailArkhipov commentedon Sep 19, 2019
I used stock install, I guess 1.2 (I don't have that machine handy atm)
jakebailey commentedon Sep 19, 2019
Also found: #1098
MikhailArkhipov commentedon Sep 26, 2019
0.4.26+
malmaud commentedon Sep 29, 2019
This issue persists for me on the 'daily' download channel. Is that expected?
MikhailArkhipov commentedon Sep 29, 2019
Can you provide some more details?
Conda on 3.6
malmaud commentedon Sep 30, 2019
Hmm, this is via
pip install torchon Python 3.7.2. Output of the language log:MikhailArkhipov commentedon Sep 30, 2019
stock 3.7
per instructions @ pytorch
malmaud commentedon Oct 14, 2019
Hmm, still not working for me
...
This is using 0.4.69.0 of the language server,
1.3of PyTorch., with these settings:on OS X with Python 3.7 on Anacadona
MikhailArkhipov commentedon Oct 14, 2019
Might be randomness of #1414
vict0rsch commentedon Feb 6, 2020
Can this be reopened? It's not fixed by #1565 unlike what's marked here
vict0rsch commentedon Feb 22, 2020
Mikhail Arkhipov (@MikhailArkhipov) ?