This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Auto completion of private methods #1154
Description
Hello,
I'm writing this issue for something that may be an error in the auto completion (it may also be a design choice) but when I create __something() private methods (or attributes), they are auto completed to _ClassName__something().
I known python internally do this transformation at runtime however, the behavior that I expected is to have this method (or attribute) auto-completed to __something().
Here is an example :
Reacted by Nicolas and Olivier Cuypers
Activity
jakebailey commentedon Jun 3, 2019
I found this the other day, you beat me to reporting it. 😃
MikhailArkhipov commentedon Jun 3, 2019
Here when class is analyzed, LS handles class data member declarations, then the constructor. In this case constructor declares
remote_idviaself.remote_id = remote_id, which then conflicts withdef remote_id. We'd need to see what exactly class members are in this case. Generally current code assumes that all class members have unique names.lauevrar77 commentedon Jun 3, 2019
I don't think it is linked to a conflict of name here. The problem also appear with simpler examples :
In my previous example remote_id became a property setter afterward.
Also, if I select this for completion, it's actually completed to
_Test__foonot to the correct value so it may not be "just" a bad tooltip.MikhailArkhipov commentedon Jun 3, 2019
This looks by design. Parser generates this name according to
https://docs.python.org/3/tutorial/classes.html#private-variables
where
__foobecomes_ClassName__foo.Any identifier of the form
__spam(at least two leading underscores, at most one trailing underscore) is textually replaced with_classname__spam, where classname is the current class name with leading underscore(s) stripped. This mangling is done without regard to the syntactic position of the identifier, as long as it occurs within the definition of a class.https://stackoverflow.com/questions/1301346/what-is-the-meaning-of-a-single-and-a-double-underscore-before-an-object-name
Having said that... Agree that it kinda makes it hard to use private variables with
self...lauevrar77 commentedon Jun 3, 2019
I know that python use this renaming convention to make private attributes or methods private at runtime (dynamic behavior) but during the implementation (static behavior), isn't it more sound to auto-complete with the approriate (static behavior) value ?
MikhailArkhipov commentedon Jun 3, 2019
Yes, agreed. What needs to change is