You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Give find and resolve coherent configuration snapshots without lock-held discovery #536
Tracking plan: #528
Priority: P2. Evidence: source-confirmed ownership inconsistency; add deterministic race tests before claiming a reproduced user failure.
Problem
Refresh uses a transient locator graph and a configuration-generation snapshot. Find/resolve still use the long-lived shared graph while configure mutates its locators one by one before publishing the new generation. Those operations can therefore observe partially applied configuration even though refresh has a coherent boundary.
Additionally, find passes a chained configuration read/clone expression directly into discovery; the temporary read guard can live through that call, retaining the configuration lock during filesystem work.
First make find's configuration snapshot an explicit local value and release its guard before discovery.
Define one coherent request-snapshot boundary for configure/refresh/find/resolve. Prefer constructing the replacement configuration/locator graph off-lock and atomically publishing it, rather than extending broad locks across I/O.
Separate deliberately shared performance caches from configured input and correctness-critical discovery state. Preserve current generation-gated notifications, locator ordering, scoped refresh-state sync, and coalescing semantics.
Replace unnecessary mutable-graph rollback complexity only where the new ownership model demonstrably removes the failure mode; do not bundle unrelated rewrites.
Acceptance criteria
Barrier/channel-driven tests prove find and resolve see either the old or new configuration, never a mix across locators.
Slow discovery/configuration fixtures do not hold a global configuration lock over filesystem or subprocess I/O.
Concurrent configures publish in a defined order; failures leave the previous usable snapshot intact.
Full/workspace/kind-filtered refresh sync, stale notification suppression, joined refresh replies, and manager fidelity retain existing behavior.
In-flight cache invalidation/clear and configuration changes have explicit tested semantics.
No regression in client-observed latency or long-lived cache behavior, and locator-state documentation includes the actual lifetime of every locator's mutable state.
Dependencies and prior work
Use #531 metrics and the #533 long-lived/concurrency workload before broad ownership changes. This establishes the ownership foundation for #539 and #540; the complete order is in #528. #385 fixed configure versus refresh isolation; #461 removed locator I/O from the configuration write lock. This issue extends consistency to find/resolve and must not regress either fix.
The explicitly separable find read-guard fix is isolated as #543 / draft #544. It releases the configuration lock before traversal and adds a deterministic blocked-discovery regression. This does not address shared-locator snapshot consistency or close #536; broader ownership work and its benchmark prerequisites remain unchanged.
The mixed-configuration risk is now deterministically reproduced against main 597b599, not just source-inferred. Two uncommitted channel-driven regressions pause a later locator before accepting the new configuration after an earlier locator has already accepted it; real file-path find and production resolution both observe new-workspace followed by old-workspace while the published generation remains 0. Both fail at the coherence assertion in 0.03 s, with all workers released/joined and bounded waits (no sleeps used as proof).
This remains isolated test/design work while #533's native workload gates finish. The intended fix is atomic publication of configuration + generation + locator graph prepared off-lock, with explicit per-locator state transfer rather than copying old configured Poetry/Conda results indiscriminately. No production snapshot change is published yet.
Activity
karthiknadig commentedon Sep 22, 2026
The explicitly separable find read-guard fix is isolated as #543 / draft #544. It releases the configuration lock before traversal and adds a deterministic blocked-discovery regression. This does not address shared-locator snapshot consistency or close #536; broader ownership work and its benchmark prerequisites remain unchanged.
fix: release find configuration lock before discovery (Fixes #543) (#544
karthiknadig commentedon Sep 30, 2026
The mixed-configuration risk is now deterministically reproduced against main
597b599, not just source-inferred. Two uncommitted channel-driven regressions pause a later locator before accepting the new configuration after an earlier locator has already accepted it; real file-path find and production resolution both observenew-workspacefollowed byold-workspacewhile the published generation remains 0. Both fail at the coherence assertion in 0.03 s, with all workers released/joined and bounded waits (no sleeps used as proof).This remains isolated test/design work while #533's native workload gates finish. The intended fix is atomic publication of configuration + generation + locator graph prepared off-lock, with explicit per-locator state transfer rather than copying old configured Poetry/Conda results indiscriminately. No production snapshot change is published yet.