Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

pgo01org: class.php uses PHP 4 style constructors #51

Closed

Description

This may negatively affect the optimization (unless we're expecting such code to be still common). The problem has already been reported, but overall it appears that intel/php_pgo_training_scripts is unmaintained. Maybe we should fork?

Activity

  1. weltling commented on Mar 27, 2019

    @weltling
    Member

    Thanks for bringing this up. I'm not sure if we can fork it under the Microsoft org, and if we can - whether it's worth the trouble. I'd suggest we consider one of the following

    • invent a patch and apply on init, or
    • bundle the source, compressed it should be fairly small

    Frankly, i'd prefer the first option, as bundling is always something that should be avoided if not strictly necessary.

    Thanks.

  2. cmb69 commented on Mar 27, 2019

    @cmb69
    ContributorAuthor

    I've filed intel/php_pgo_training_scripts#3. Maybe it'll be accepted; otherwise we could use it as patch.

  3. weltling commented on Mar 28, 2019

    @weltling
    Member

    Christoph M. Becker (@cmb69) thanks for filing the PR upstream, but not sure to expect that one to be merged soon :) In might make sense integrating the patch at some point. Or actually not patch, but do a simple search/replace like here https://github.com/Microsoft/php-sdk-binary-tools/blob/master/pgo/cases/pgo01org/TrainingCaseHandler.php#L83. It won't fail, if the PR has been merged anyway.

    Thanks.

  4. cmb69 commented on Mar 31, 2019

    @cmb69
    ContributorAuthor

    I've implemented a search and replace workaround as PR #53.

  5. weltling commented on Mar 31, 2019

    @weltling
    Member

    PR merged.

    Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions